From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 2/3] net: fec: do not access reserved register for i.MX6UL
Date: Tue, 1 Sep 2015 09:15:56 +0200 [thread overview]
Message-ID: <55E550AC.6070906@denx.de> (raw)
In-Reply-To: <20150901003256.GA12983@shlinux2>
Hi Peng,
On 01/09/2015 02:32, Peng Fan wrote:
>> Patch is already applied - however, I have found that this break build
>> for vf610 boards (they have not a get_cpu_rev()). You can check with the
>> current u-boot-imx.
>>
>
> Sorry, I checked all i.MXes, but missed vf610.
No problem - we fix it !
>
>> Can you take a look, please ?
>
> I worked a simple patch: https://patchwork.ozlabs.org/patch/512669/
> Add an empty function to avoid build errors. Current we do not have
> drivers to check vf610 cpu types, later if we need saying
> "is_cpu_type(VF610)", we can add more stuff to the function get_cpu_rev
> for vf610.
>
I hoped to have a right get_cpu_rev() for VF610, too. Then I checked in
the VF610 manual, but I found revision only for specific controllers -
EHCI, etc. I have not found anything equivalent, but maybe it is better
hidden.
Of course, we can do with an empty function if we have not something
better. Maybe do you can check in Freescale if there is a way to get the
cpu revision instead of a dummy ?
Thanks,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2015-09-01 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 9:40 [U-Boot] [PATCH V2 1/3] imx: clock support enet2 anatop clock support Peng Fan
2015-08-12 9:40 ` [U-Boot] [PATCH V2 2/3] net: fec: do not access reserved register for i.MX6UL Peng Fan
2015-08-12 19:15 ` Joe Hershberger
2015-08-23 15:43 ` Stefano Babic
2015-08-31 17:14 ` Stefano Babic
2015-09-01 0:32 ` Peng Fan
2015-09-01 7:15 ` Stefano Babic [this message]
2015-08-12 9:40 ` [U-Boot] [PATCH V2 3/3] imx: mx6ul_14x14_evk add ENET support Peng Fan
2015-08-12 8:34 ` Peng Fan
2015-08-23 15:45 ` Stefano Babic
2015-08-24 0:07 ` Peng Fan
2015-08-24 7:31 ` Stefano Babic
2015-08-24 6:35 ` Peng Fan
2015-08-23 15:43 ` [U-Boot] [PATCH V2 1/3] imx: clock support enet2 anatop clock support Stefano Babic
-- strict thread matches above, loose matches on Subject: below --
2015-08-12 9:46 Peng Fan
2015-08-12 9:46 ` [U-Boot] [PATCH V2 2/3] net: fec: do not access reserved register for i.MX6UL Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E550AC.6070906@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox