From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/8] zynq: Move SPL console init out of board_init_f()
Date: Tue, 1 Sep 2015 10:44:23 +0200 [thread overview]
Message-ID: <55E56567.6090508@monstr.eu> (raw)
In-Reply-To: <1440795028-7303-8-git-send-email-sjg@chromium.org>
On 08/28/2015 10:50 PM, Simon Glass wrote:
> We should not init the console this early and there is no need to. If we want
> to do early init it can be done in spl_board_init(). Move the
> preloader_console_init() call from board_init_f() to board_init_r().
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Tested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2: None
>
> arch/arm/mach-zynq/spl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-zynq/spl.c b/arch/arm/mach-zynq/spl.c
> index e7df6d3..7bdac3b 100644
> --- a/arch/arm/mach-zynq/spl.c
> +++ b/arch/arm/mach-zynq/spl.c
> @@ -20,7 +20,6 @@ void board_init_f(ulong dummy)
> /* Clear the BSS. */
> memset(__bss_start, 0, __bss_end - __bss_start);
>
> - preloader_console_init();
> arch_cpu_init();
> board_init_r(NULL, 0);
> }
> @@ -28,6 +27,7 @@ void board_init_f(ulong dummy)
> #ifdef CONFIG_SPL_BOARD_INIT
> void spl_board_init(void)
> {
> + preloader_console_init();
> board_init();
> }
> #endif
>
Tested-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150901/1ec9b138/attachment.sig>
next prev parent reply other threads:[~2015-09-01 8:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 20:50 [U-Boot] [PATCH v2 0/8] arm: Tidy up early init Simon Glass
2015-08-28 20:50 ` [U-Boot] [PATCH v2 1/8] Move board_init_f_mem() into a common location Simon Glass
2015-08-28 20:50 ` [U-Boot] [PATCH v2 2/8] board_init_f_mem(): Don't require memset() Simon Glass
2015-08-28 20:50 ` [U-Boot] [PATCH v2 3/8] board_init_f_mem(): Don't create an unused early malloc() area Simon Glass
2015-08-28 20:50 ` [U-Boot] [PATCH v2 4/8] arm: Switch aarch64 to using generic global_data setup Simon Glass
2015-08-28 20:50 ` [U-Boot] [PATCH v2 5/8] arm: Switch 32-bit ARM " Simon Glass
2015-08-28 20:50 ` [U-Boot] [PATCH v2 6/8] microblaze: Add a TODO to call board_init_f_mem() Simon Glass
2015-09-01 8:45 ` Michal Simek
2015-08-28 20:50 ` [U-Boot] [PATCH v2 7/8] zynq: Move SPL console init out of board_init_f() Simon Glass
2015-09-01 8:44 ` Michal Simek [this message]
2015-08-28 20:50 ` [U-Boot] [PATCH v2 8/8] Revert "ARM: zynq: disable CONFIG_SYS_MALLOC_F to fix MMC boot" Simon Glass
2015-09-01 8:57 ` Michal Simek
2015-09-01 9:10 ` [U-Boot] [PATCH v2 0/8] arm: Tidy up early init Michal Simek
2015-09-02 2:48 ` Simon Glass
2015-09-03 11:13 ` Michal Simek
2015-09-04 23:42 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E56567.6090508@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox