[U-Boot] [PATCH 13/13] arm: zynq: Move serial driver to driver model

Simon Glass
2015-08-31T13:54:40Z

Hi Michal,

On 31 August 2015 at 05:33, Michal Simek <monstr@monstr.eu> wrote:
> On 08/29/2015 05:10 PM, Simon Glass wrote:
>> Update this driver to use driver model and change all users.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> arch/arm/Kconfig | 1 +
>> drivers/serial/serial_zynq.c | 162 ++++++++++++++++------------------------
>> include/configs/zynq_microzed.h | 1 -
>> include/configs/zynq_picozed.h | 1 -
>> include/configs/zynq_zc70x.h | 1 -
>> include/configs/zynq_zc770.h | 6 --
>> include/configs/zynq_zed.h | 1 -
>> include/configs/zynq_zybo.h | 1 -
>> 8 files changed, 65 insertions(+), 109 deletions(-)
>>
>
> Unfortunately you forget to move ZynqMP target to DM. I have done it in
> our internal tree and it is probably the right time to send that patches
> out to cover it. Definitely they have to come to the tree first.

See my note in the cover letter. ZynqMP does not build for me and I
cannot see any device tree files in U-Boot.

>
> I will test all others patches but TBH I have moved serial driver but I
> didn't resolved that SPL case but it is wonderful that you have probably
> fixed it. I am looking for to see what will be sizes with and without DM.

Yes, it will be larger. Likely there is some optimisation that can be
done - I put some effort into this on Rockchip. Once we have a
reasonable selection of boards using this in SPL we should review it
carefully and see how to improve code size / performance.
Fundamentally (in terms of architectural design) I think it is
reasonable, but it is worth putting effort in to achieve the best
possible result.

Regards,
Simon