From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] DM: Problem with DT bus translation dev_get_addr()
Date: Tue, 1 Sep 2015 18:52:09 +0200 [thread overview]
Message-ID: <55E5D7B9.7000401@denx.de> (raw)
In-Reply-To: <CAPnjgZ2k3CmF2dEnCNRnUdTROo3cGNC0rcQf0GL-RxHqwWnNRw@mail.gmail.com>
Hi Simon,
On 01.09.2015 17:30, Simon Glass wrote:
>>> So my main question is, why don't you use fdt_translate_address()
>>> from fdt_support.c instead of implementing your own translation
>>> function simple_bus_translate()? Is this a size question because
>>> this may be used in SPL as well?
>>
>>
>> The attached small patch demonstrates the usage of fdt_translate_address()
>> and enables bus translation on the MVEBU platforms.
>
> Thanks for digging into this.
>
> One concern I have is fdt_parent_offset(). That function is very slow
> - we should use dev->parent->of_offset instead with driver model.
>
> Other than that I think this is fine. But yes it should be enabled by
> CONFIG because the code size gets a lot larger and many platforms
> don't need it. Perhaps we should have a new CONFIG_SPL_OF_TRANSLATE?
Okay. I'll try to prepare a patch for this tomorrow. Stay tuned... ;)
Thanks,
Stefan
prev parent reply other threads:[~2015-09-01 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 6:25 [U-Boot] DM: Problem with DT bus translation dev_get_addr() Stefan Roese
2015-09-01 15:23 ` Stefan Roese
2015-09-01 15:30 ` Simon Glass
2015-09-01 16:52 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5D7B9.7000401@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox