From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] distro_bootcmd: Add support for booting from ubifs
Date: Tue, 1 Sep 2015 13:13:30 -0700 [thread overview]
Message-ID: <55E606EA.9020103@wwwdotorg.org> (raw)
In-Reply-To: <1440266693-15664-5-git-send-email-hdegoede@redhat.com>
On 08/22/2015 11:04 AM, Hans de Goede wrote:
> From: Roy Spliet <r.spliet@ultimaker.com>
>
> Under the assumptions of having a UBI volume called boot, containing
> a ubifs filesystem.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
I'd expect the person in the "From:" line above to have an s-o-b line
too. If the patch has changed so much that isn't appropriate, perhaps
change the patch's git author to you and just mentioned "Based on work
by: Roy ..."?
> diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h
> +#ifdef CONFIG_CMD_UBIFS
> +#define BOOTENV_SHARED_UBIFS \
> + "ubifs_boot=" \
> + "if ubi part UBI && ubifsmount ubi${devnum}:boot; then " \
I don't know ubifs well enough to know the implications of that
particular set of ubi commands, but as far as the
impact-on/integration-into the bootcmd.h file, this patch looks fine.
Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2015-09-01 20:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 18:04 [U-Boot] [PATCH v2 0/4] distro_bootcmd: Add support for booting from ubifs Hans de Goede
2015-08-22 18:04 ` [U-Boot] [PATCH v2 1/4] ubifs: Modify ubifs u-boot wrapper function prototypes for generic fs use Hans de Goede
2015-08-25 11:00 ` Heiko Schocher
2015-08-25 11:32 ` Hans de Goede
2015-08-28 14:52 ` Tom Rini
2015-08-28 15:33 ` Heiko Schocher
2015-08-31 16:08 ` Hans de Goede
2015-09-01 3:46 ` Heiko Schocher
2015-09-01 10:57 ` Heiko Schocher
2015-08-22 18:04 ` [U-Boot] [PATCH v2 2/4] ubifs: Add functions " Hans de Goede
2015-08-25 11:02 ` Heiko Schocher
2015-09-01 19:57 ` Stephen Warren
2015-09-01 20:01 ` Michael Trimarchi
2015-09-14 17:29 ` Hans de Goede
2015-08-22 18:04 ` [U-Boot] [PATCH v2 3/4] ubifs: Add generic fs support Hans de Goede
2015-08-25 11:20 ` Heiko Schocher
2015-09-01 20:03 ` Stephen Warren
2015-09-14 17:35 ` Hans de Goede
2015-09-21 18:11 ` Stephen Warren
2015-08-22 18:04 ` [U-Boot] [PATCH v2 4/4] distro_bootcmd: Add support for booting from ubifs Hans de Goede
2015-09-01 20:13 ` Stephen Warren [this message]
2015-09-14 17:48 ` Hans de Goede
2015-08-24 16:57 ` [U-Boot] [PATCH v2 0/4] " Scott Wood
2015-08-25 7:15 ` Hans de Goede
2015-08-25 7:31 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E606EA.9020103@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox