From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix FSL DDR clock adjust calculation.
Date: Wed, 2 Sep 2015 08:35:21 -0500 [thread overview]
Message-ID: <55E6FB19.6090900@freescale.com> (raw)
In-Reply-To: <1441194061-28527-1-git-send-email-joakim.tjernlund@transmode.se>
On 09/02/2015 06:41 AM, Joakim Tjernlund wrote:
> T1040 RM specifies CLK_ADJUST as 5 bits starting at bit pos 9
> in DDR_DDR_SDRAM_CLK_CNTL, update code to match.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
> ---
> drivers/ddr/fsl/ctrl_regs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ddr/fsl/ctrl_regs.c b/drivers/ddr/fsl/ctrl_regs.c
> index 3919257..57077e1 100644
> --- a/drivers/ddr/fsl/ctrl_regs.c
> +++ b/drivers/ddr/fsl/ctrl_regs.c
> @@ -1756,7 +1756,7 @@ static void set_ddr_sdram_clk_cntl(fsl_ddr_cfg_regs_t *ddr,
> clk_adjust = popts->clk_adjust;
> ddr->ddr_sdram_clk_cntl = (0
> | ((ss_en & 0x1) << 31)
> - | ((clk_adjust & 0xF) << 23)
> + | ((clk_adjust & 0x1F) << 22)
> );
> debug("FSLDDR: clk_cntl = 0x%08x\n", ddr->ddr_sdram_clk_cntl);
> }
>
NACK. This is logically correct but it needs to consider all DDR controllers.
Older controllers don't have the same bits for this field. So far we don't have
to use this this fine granularity on clock adjustment.
York
next prev parent reply other threads:[~2015-09-02 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 11:41 [U-Boot] [PATCH] Fix FSL DDR clock adjust calculation Joakim Tjernlund
2015-09-02 13:35 ` York Sun [this message]
2015-09-02 14:31 ` Joakim Tjernlund
2015-09-02 14:34 ` York Sun
2015-09-02 14:42 ` Joakim Tjernlund
2015-09-02 14:51 ` York Sun
2015-09-02 15:06 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E6FB19.6090900@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox