From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Grinberg <grinberg@compulab.co.il>
Date: Sun, 6 Sep 2015 15:58:14 +0300
Subject: [U-Boot] [PATCH V2 2/4] compulab: eeprom: propagate error value
 in read_mac_addr()
In-Reply-To: <1441529318-23973-3-git-send-email-nikita@compulab.co.il>
References: <1441529318-23973-1-git-send-email-nikita@compulab.co.il>
 <1441529318-23973-3-git-send-email-nikita@compulab.co.il>
Message-ID: <55EC3866.5050504@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/06/15 11:48, Nikita Kiryanov wrote:
> cl_eeprom_read_mac_addr() doesn't differentiate between success case and
> inability to access eeprom. Fix this by propagating the return value of
> cl_eeprom_setup().
> 
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

> ---
> Changes in V2:
> 	- New patch
> 
>  board/compulab/common/eeprom.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/board/compulab/common/eeprom.c b/board/compulab/common/eeprom.c
> index aaacd2e..9f18a3d 100644
> --- a/board/compulab/common/eeprom.c
> +++ b/board/compulab/common/eeprom.c
> @@ -105,9 +105,11 @@ void get_board_serial(struct tag_serialnr *serialnr)
>  int cl_eeprom_read_mac_addr(uchar *buf, uint eeprom_bus)
>  {
>  	uint offset;
> +	int err;
>  
> -	if (cl_eeprom_setup(eeprom_bus))
> -		return 0;
> +	err = cl_eeprom_setup(eeprom_bus);
> +	if (err)
> +		return err;
>  
>  	offset = (cl_eeprom_layout != LAYOUT_LEGACY) ?
>  			MAC_ADDR_OFFSET : MAC_ADDR_OFFSET_LEGACY;
> 

-- 
Regards,
Igor.