From mboxrd@z Thu Jan  1 00:00:00 1970
From: ivan.khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Tue, 8 Sep 2015 21:01:05 +0300
Subject: [U-Boot] [PATCH v5] bitops: introduce BIT() definition
In-Reply-To: <1441626234-16364-1-git-send-email-andreas.devel@googlemail.com>
References: <1440176519-30102-2-git-send-email-hs@denx.de>
 <1441626234-16364-1-git-send-email-andreas.devel@googlemail.com>
Message-ID: <55EF2261.7090502@globallogic.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi, Andreas

On 07.09.15 14:43, Andreas Bie?mann wrote:
> From: Heiko Schocher <hs@denx.de>
>
> introduce BIT() definition, used in at91_udc gadget
> driver.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> [remove all other occurrences of BIT(x) definition]
> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> ---
> Full buildman is running
>

....

>
> +#define BIT(nr)		(1UL << (nr))

Why UL? Why not simply 1 << (nr)?
What if I need set ULL bit on 32-bit system?
Thanks for explanation.

> +
>   /*
>    * ffs: find first bit set. This is defined the same way as
>    * the libc and compiler builtin ffs routines, therefore
>