From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 9 Sep 2015 09:37:17 +0200 Subject: [U-Boot] [PATCH 3/4] mx6ul_14x14_evk: Remove CONFIG_SPL_FAT_SUPPORT In-Reply-To: <20150909032915.GB7343@shlinux2> References: <1441734192-21326-1-git-send-email-fabio.estevam@freescale.com> <1441734192-21326-3-git-send-email-fabio.estevam@freescale.com> <20150909032915.GB7343@shlinux2> Message-ID: <55EFE1AD.2080902@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Peng, Fabio, On 09/09/2015 05:29, Peng Fan wrote: > Hi Fabio, > > On Tue, Sep 08, 2015 at 02:43:11PM -0300, Fabio Estevam wrote: >> If the SD card does not contain the u-boot.img then we get the >> following error: >> >> U-Boot SPL 2015.10-rc2-23947-g7ad5930 (Sep 08 2015 - 14:10:29) >> ** Partition 1 not valid on device 0 ** >> spl_register_fat_device: fat register err - -1 >> spl_load_image_fat: error reading image u-boot.img, err - -1 >> >> Remove CONFIG_SPL_FAT_SUPPORT and let CONFIG_SPL_MMC_SUPPORT do the >> job. >> >> Signed-off-by: Fabio Estevam >> --- >> include/configs/mx6ul_14x14_evk.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/configs/mx6ul_14x14_evk.h b/include/configs/mx6ul_14x14_evk.h >> index 4a2280b..e785925 100644 >> --- a/include/configs/mx6ul_14x14_evk.h >> +++ b/include/configs/mx6ul_14x14_evk.h >> @@ -17,7 +17,6 @@ >> /* SPL options */ >> #define CONFIG_SPL_LIBCOMMON_SUPPORT >> #define CONFIG_SPL_MMC_SUPPORT >> -#define CONFIG_SPL_FAT_SUPPORT > > Can we keep this? Without this, we need to burn u-boot.img into sdcard, but > i prefer to load u-boot.img from the fat partition. Well, how U-Boot is stored on the SD-Card is a decision that you take based on the balance safety against comfortably. Both are ok on my side. If we put u-boot.img in raw SD at a fixed address, it is very uncommon that a user destroy accessing it. On the other side, putting it into a FAT partition makes easier to update for everybody - just copying it into a disk. The issue reported by Fabio is like a corrupted SD-Card - the SD-Card does not contain the correct bootloader and it is ok if it does not boot or hangs. Both ways have advantages and disadvantages. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================