From: Mugunthan V N <mugunthanvnm@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fdt: add new fdt address parsing functions
Date: Fri, 11 Sep 2015 16:24:47 +0530 [thread overview]
Message-ID: <55F2B2F7.2090003@ti.com> (raw)
In-Reply-To: <CAPnjgZ0eW49n3QjWkUFY2HqBbs1XSpntR2LTbpuSjJ2BowO6Tw@mail.gmail.com>
On Wednesday 09 September 2015 11:38 PM, Simon Glass wrote:
> Hi,
>
> On Monday, 7 September 2015, Mugunthan V N <mugunthanvnm@ti.com> wrote:
>>
>> On Friday 07 August 2015 03:01 AM, Stephen Warren wrote:
>>> From: Stephen Warren <swarren@nvidia.com>
>>>
>>> fdtdec_get_addr_size() hard-codes the number of cells used to represent
>>> an address or size in DT. This is incorrect in many cases depending on
>>> the DT binding for a particular node or property (e.g. it is incorrect
>>> for the "reg" property). In most cases, DT parsing code must use the
>>> properties #address-cells and #size-cells to parse addres properties.
>>>
>>> This change splits up the implementation of fdtdec_get_addr_size() so
>>> that the core logic can be used for both hard-coded and non-hard-coded
>>> cases. Various wrapper functions are implemented that support cases
>>> where hard-coded cell counts should or should not be used, and where
>>> the client does and doesn't know the parent node ID that contains the
>>> properties #address-cells and #size-cells.
>>>
>>> dev_get_addr() is updated to use the new functions.
>>>
>>> Core functionality in fdtdec_get_addr_size_fixed() is widely tested via
>>> fdtdec_get_addr_size(). I tested fdtdec_get_addr_size_auto_noparent() and
>>> dev_get_addr() by manually modifying the Tegra I2C driver to invoke them.
>>>
>>> Much of the core implementation of fdtdec_get_addr_size_fixed(),
>>> fdtdec_get_addr_size_auto_parent(), and
>>> fdtdec_get_addr_size_auto_noparent() comes from Thierry Reding's
>>> previous commit "fdt: Fix fdtdec_get_addr_size() for 64-bit".
>>
>> Tested this patch for cpsw ethernet dt migration to getting cpsw address
>> space. Also dropped *#define DEBUG* in lib/fdtdev.c file.
>>
>> Tested-by: Mugunthan V N <mugunthanvnm@ti.com>
>>
> Thanks for testing this. I would like to apply this - are there any
> other comments?
>
There is no other comments apart from removing #define DEBUG
Regards
Mugunthan V N
next prev parent reply other threads:[~2015-09-11 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 21:31 [U-Boot] [PATCH] fdt: add new fdt address parsing functions Stephen Warren
2015-08-06 21:35 ` Stephen Warren
2015-08-09 15:07 ` Simon Glass
2015-09-07 8:22 ` Mugunthan V N
2015-09-09 18:08 ` Simon Glass
2015-09-11 10:54 ` Mugunthan V N [this message]
2015-09-15 7:55 ` Mugunthan V N
2015-09-15 19:17 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F2B2F7.2090003@ti.com \
--to=mugunthanvnm@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox