public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: Tweak various memory addresses
Date: Sun, 13 Sep 2015 19:03:46 +0200	[thread overview]
Message-ID: <55F5AC72.5040309@redhat.com> (raw)
In-Reply-To: <20150913165450.GA4929@excalibur.cnev.de>

Hi,

On 13-09-15 18:54, Karsten Merker wrote:
> On Sun, Sep 13, 2015 at 05:25:57PM +0200, Hans de Goede wrote:
>
>> For the upcoming nand support we need a bigger heap, esp. ubi[fs] uses
>> quite a bit of memory, increase the heap size to 64 MB.
> [...]
>>   /*
>> - * 240M RAM (256M minimum minus space for the framebuffer),
>> + * 160M RAM (256M minimum minus 64MB heap + 32MB for u-boot, stack, fb, etc.
>>    * 32M uncompressed kernel, 16M compressed kernel, 1M fdt,
>>    * 1M script, 1M pxe and the ramdisk at the end.
>>    */
>>   #define MEM_LAYOUT_ENV_SETTINGS \
>> -	"bootm_size=0xf000000\0" \
>> +	"bootm_size=0xa000000\0" \
>>   	"kernel_addr_r=" __stringify(SDRAM_OFFSET(2000000)) "\0" \
>>   	"fdt_addr_r=" __stringify(SDRAM_OFFSET(3000000)) "\0" \
>>   	"scriptaddr=" __stringify(SDRAM_OFFSET(3100000)) "\0" \
>
> Hello,
>
> I am just thinking about the case where somebody upgrades an
> existing u-boot on an SD card to a new version with NAND support
> and then tries to run NAND-related commands.  In that case there
> would still be the old bootm_size setting in the environment, so
> that NAND-related commands might fail due to not enough heap.
>
> Is there some kind of "release notes" document where we could
> note that on upgrading the user should run "env default
> bootm_size; saveenv" or something alike?

Actually bootm_size is only used to determine where to relocate
the kernel / initrd when doing a bootm command, and that relocation
rarely happens. And the new bootm_size is only needed on 256M boards,
of which we have only 1.

Moreover I do not expect a lot people to have ever done a saveenv
command.

Regards,

Hans

      parent reply	other threads:[~2015-09-13 17:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 15:25 [U-Boot] [PATCH] sunxi: Tweak various memory addresses Hans de Goede
2015-09-13 16:26 ` Ian Campbell
     [not found] ` <20150913165450.GA4929@excalibur.cnev.de>
2015-09-13 17:03   ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F5AC72.5040309@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox