From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludger Dreier <Ludger.Dreier@keymile.com>
Date: Wed, 16 Sep 2015 13:46:34 +0200
Subject: [U-Boot] [PATCH] Revert "env_eeprom: Assign default environment
 during board_init_f"
In-Reply-To: <20150915165437.GH26226@bill-the-cat>
References: <55F7E667.1040802@keymile.com>
 <20150915165437.GH26226@bill-the-cat>
Message-ID: <55F9569A.4010401@keymile.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Tom,

Am 2015-09-15 18:54, schrieb Tom Rini:
> Was there perhaps some sort of init ordering issue in a board which
> did have EEPROM used as the backing store for env?  I could see a
> case where perhaps (and Ludger, can you test this as well please?)
> the problem is that for env_eeprom env_init() needs to just default
> to the built-in (like it's basically doing today) and
> env_relocate_spec() needs to do the read, check which is valid, etc,
> etc, dance which it is _not_ doing today.
> 

as I understand your idea, the code from both versions of env_init
(redundant env and non-redunant) which is framed by 
"#ifdef ENV_IS_EMBEDDED" may potentially be moved to, or called by
env_relocate_spec. I think this could work. If this ok for you,
I can come up with a tested proposal. But this would need some days.

Ludger