[U-Boot] [linux-sunxi] Re: [PATCH 3/6] sunxi: Add the R8 DTSI

Julian Calaby
2015-09-18T23:31:52Z

Hi,

On Sat, Sep 19, 2015 at 1:39 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 09/18/2015 11:39 AM, Tom Rini wrote:
>>
>> On Fri, Sep 18, 2015 at 11:17:00AM -0400, Hans de Goede wrote:
>>>
>>> Hi,
>>>
>>> On 09/18/2015 11:02 AM, Tom Rini wrote:
>>>>
>>>> On Fri, Sep 18, 2015 at 02:06:17PM +0200, Maxime Ripard wrote:
>>>>
>>>>> The R8 is very close to the A13, but it still has a few differences,
>>>>> notably a composite output, which the A13 lacks.
>>>>>
>>>>> Add a DTSI based on the A13's to hold those differences.
>>>>>
>>>>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>>>>
>>>>
>>>> Other than needing to use SPDX tags instead:
>>>> Reviewed-by: Tom Rini <trini@konsulko.com>
>>>
>>>
>>> This is in essence a partial sync with the kernel tree wrt the dts
>>> files, so no SPDX tags.
>>
>>
>> Really? I'd have sworn that we were doing that even on kernel files,
>
>
> I don't know. I'm fine either way, but I do not think we should be
> adding SPDX tags on the u-boot side only for these files, since those
> will just get overwritten (removed) on the next sync with the kernel.

Would it make sense to just add them kernel side?

Thanks,

--
Julian Calaby

Email: julian.calaby at gmail.com
Profile: http://www.google.com/profiles/julian.calaby/