public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [linux-sunxi] [PATCH 2/6] fastboot: Implement OEM format only when we have MMC support
Date: Fri, 18 Sep 2015 10:53:51 -0400	[thread overview]
Message-ID: <55FC257F.3080402@redhat.com> (raw)
In-Reply-To: <1442577980-26373-3-git-send-email-maxime.ripard@free-electrons.com>

Hi,

On 09/18/2015 08:06 AM, Maxime Ripard wrote:
> The current fastboot support assumes that CONFIG_FASTBOOT_FLASH implies
> that we have an MMC in our system, which might not be the case if we have
> some other storage device.
>
> Change the configuration option protecting that call to
> FASTBOOT_FLASH_MMC_DEV, that makes much more sense.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Note I'm not going to take this one upstream through the sunxi tree,
other then that it looks fine to me.

Regards,

Hans


> ---
>   drivers/usb/gadget/f_fastboot.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
> index ca01a018b5d1..ece48e668c96 100644
> --- a/drivers/usb/gadget/f_fastboot.c
> +++ b/drivers/usb/gadget/f_fastboot.c
> @@ -554,7 +554,7 @@ static void cb_flash(struct usb_ep *ep, struct usb_request *req)
>   static void cb_oem(struct usb_ep *ep, struct usb_request *req)
>   {
>   	char *cmd = req->buf;
> -#ifdef CONFIG_FASTBOOT_FLASH
> +#ifdef CONFIG_FASTBOOT_FLASH_MMC_DEV
>   	if (strncmp("format", cmd + 4, 6) == 0) {
>   		char cmdbuf[32];
>                   sprintf(cmdbuf, "gpt write mmc %x $partitions",
>

  reply	other threads:[~2015-09-18 14:53 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 12:06 [U-Boot] [PATCH 0/6] ARM: sunxi: Introduce CHIP support Maxime Ripard
2015-09-18 12:06 ` [U-Boot] [PATCH 1/6] sunxi: Add an option to disable MMC Maxime Ripard
2015-09-18 14:52   ` [U-Boot] [linux-sunxi] " Hans de Goede
2015-09-22  9:12     ` Maxime Ripard
2015-09-18 15:02   ` [U-Boot] " Tom Rini
2015-09-18 15:04     ` Hans de Goede
2015-09-22  9:15     ` Maxime Ripard
2015-09-18 12:06 ` [U-Boot] [PATCH 2/6] fastboot: Implement OEM format only when we have MMC support Maxime Ripard
2015-09-18 14:53   ` Hans de Goede [this message]
2015-09-22  9:02     ` [U-Boot] [linux-sunxi] " Maxime Ripard
2015-09-18 15:02   ` [U-Boot] " Tom Rini
2015-09-22  9:00     ` Maxime Ripard
2015-09-18 12:06 ` [U-Boot] [PATCH 3/6] sunxi: Add the R8 DTSI Maxime Ripard
2015-09-18 15:02   ` Tom Rini
2015-09-18 15:17     ` [U-Boot] [linux-sunxi] " Hans de Goede
2015-09-18 15:39       ` Tom Rini
2015-09-18 15:39         ` Hans de Goede
2015-09-18 15:49           ` Tom Rini
2015-09-18 23:31           ` Julian Calaby
2015-09-19 11:13             ` Tom Rini
2015-09-22  9:22               ` Maxime Ripard
2015-09-18 15:08   ` [U-Boot] " Ian Campbell
2015-09-22  9:17     ` Maxime Ripard
2015-09-22  9:20       ` Ian Campbell
2015-09-22 12:08         ` Maxime Ripard
2015-09-18 12:06 ` [U-Boot] [PATCH 4/6] ARM: sun5i: dt: Move uart3 pinctrl node to common DTSI Maxime Ripard
2015-09-18 15:02   ` Tom Rini
2015-09-18 12:06 ` [U-Boot] [PATCH 5/6] ARM: sun5i: dt: Add UART3 CTS and RTS pins Maxime Ripard
2015-09-18 15:02   ` Tom Rini
2015-09-18 12:06 ` [U-Boot] [PATCH 6/6] sunxi: Add CHIP support Maxime Ripard
2015-09-18 14:55   ` [U-Boot] [linux-sunxi] " Hans de Goede
2015-09-18 15:02   ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FC257F.3080402@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox