* [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver
@ 2015-09-18 15:29 Olliver Schinagl
2015-09-21 1:50 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Olliver Schinagl @ 2015-09-18 15:29 UTC (permalink / raw)
To: u-boot
From: Olliver Schinagl <o.schinagl@ultimaker.com>
The designware driver has a build guard which makes it to only work when
using the PHYLIB. With b68fe152272 the PHYLIB was added to the net
Kconfig but not selected by all hardware depending on it.
This patch enables PHYLIB for the Designware MAC
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
---
drivers/net/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index bbec6a6..51b1668 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
config ETH_DESIGNWARE
bool "Synopsys Designware Ethernet MAC"
+ select PHYLIB
help
This MAC is present in SoCs from various vendors. It supports
- 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
- provide the PHY (physical media interface).
+ 100Mbit and 1 Gbit operation.
config PCH_GBE
bool "Intel Platform Controller Hub EG20T GMAC driver"
--
2.5.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver
2015-09-18 15:29 [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver Olliver Schinagl
@ 2015-09-21 1:50 ` Bin Meng
2015-09-21 7:18 ` Olliver Schinagl
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2015-09-21 1:50 UTC (permalink / raw)
To: u-boot
Hi Olliver,
On Fri, Sep 18, 2015 at 11:29 PM, Olliver Schinagl
<oliver+list@schinagl.nl> wrote:
> From: Olliver Schinagl <o.schinagl@ultimaker.com>
>
> The designware driver has a build guard which makes it to only work when
> using the PHYLIB. With b68fe152272 the PHYLIB was added to the net
> Kconfig but not selected by all hardware depending on it.
>
> This patch enables PHYLIB for the Designware MAC
>
> Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
> ---
> drivers/net/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index bbec6a6..51b1668 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
>
> config ETH_DESIGNWARE
> bool "Synopsys Designware Ethernet MAC"
> + select PHYLIB
> help
> This MAC is present in SoCs from various vendors. It supports
> - 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
> - provide the PHY (physical media interface).
> + 100Mbit and 1 Gbit operation.
>
> config PCH_GBE
> bool "Intel Platform Controller Hub EG20T GMAC driver"
> --
This is not enough. You need update all borads' config.h files to
remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver
2015-09-21 1:50 ` Bin Meng
@ 2015-09-21 7:18 ` Olliver Schinagl
2015-09-21 7:24 ` Bin Meng
0 siblings, 1 reply; 5+ messages in thread
From: Olliver Schinagl @ 2015-09-21 7:18 UTC (permalink / raw)
To: u-boot
Hey Bin,
On 21-09-15 03:50, Bin Meng wrote:
> Hi Olliver,
>
> On Fri, Sep 18, 2015 at 11:29 PM, Olliver Schinagl
> <oliver+list@schinagl.nl> wrote:
>> From: Olliver Schinagl <o.schinagl@ultimaker.com>
>>
>> The designware driver has a build guard which makes it to only work when
>> using the PHYLIB. With b68fe152272 the PHYLIB was added to the net
>> Kconfig but not selected by all hardware depending on it.
>>
>> This patch enables PHYLIB for the Designware MAC
>>
>> Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
>> ---
>> drivers/net/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index bbec6a6..51b1668 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
>>
>> config ETH_DESIGNWARE
>> bool "Synopsys Designware Ethernet MAC"
>> + select PHYLIB
>> help
>> This MAC is present in SoCs from various vendors. It supports
>> - 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>> - provide the PHY (physical media interface).
>> + 100Mbit and 1 Gbit operation.
>>
>> config PCH_GBE
>> bool "Intel Platform Controller Hub EG20T GMAC driver"
>> --
> This is not enough. You need update all borads' config.h files to
> remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.
I was being conservative here,
Is it enough to only do the boards that are featured using Kconfig?
>
> Regards,
> Bin
--
Met vriendelijke groeten, Kind regards, ??????
Olliver Schinagl
Research & Development
Ultimaker B.V.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver
2015-09-21 7:18 ` Olliver Schinagl
@ 2015-09-21 7:24 ` Bin Meng
2015-09-21 8:08 ` Olliver Schinagl
0 siblings, 1 reply; 5+ messages in thread
From: Bin Meng @ 2015-09-21 7:24 UTC (permalink / raw)
To: u-boot
Hi Olliver,
On Mon, Sep 21, 2015 at 3:18 PM, Olliver Schinagl
<o.schinagl@ultimaker.com> wrote:
> Hey Bin,
>
>
> On 21-09-15 03:50, Bin Meng wrote:
>>
>> Hi Olliver,
>>
>> On Fri, Sep 18, 2015 at 11:29 PM, Olliver Schinagl
>> <oliver+list@schinagl.nl> wrote:
>>>
>>> From: Olliver Schinagl <o.schinagl@ultimaker.com>
>>>
>>> The designware driver has a build guard which makes it to only work when
>>> using the PHYLIB. With b68fe152272 the PHYLIB was added to the net
>>> Kconfig but not selected by all hardware depending on it.
>>>
>>> This patch enables PHYLIB for the Designware MAC
>>>
>>> Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
>>> ---
>>> drivers/net/Kconfig | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>> index bbec6a6..51b1668 100644
>>> --- a/drivers/net/Kconfig
>>> +++ b/drivers/net/Kconfig
>>> @@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
>>>
>>> config ETH_DESIGNWARE
>>> bool "Synopsys Designware Ethernet MAC"
>>> + select PHYLIB
>>> help
>>> This MAC is present in SoCs from various vendors. It supports
>>> - 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>>> - provide the PHY (physical media interface).
>>> + 100Mbit and 1 Gbit operation.
>>>
>>> config PCH_GBE
>>> bool "Intel Platform Controller Hub EG20T GMAC driver"
>>> --
>>
>> This is not enough. You need update all borads' config.h files to
>> remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.
>
> I was being conservative here,
>
> Is it enough to only do the boards that are featured using Kconfig?
I think all boards have been converted to Kconfig, no?
>>
>>
>> Regards,
>> Bin
>
>
> --
> Met vriendelijke groeten, Kind regards, ??????
Ah, you know Chinese :-)
>
> Olliver Schinagl
> Research & Development
> Ultimaker B.V.
>
Regards,
Bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver
2015-09-21 7:24 ` Bin Meng
@ 2015-09-21 8:08 ` Olliver Schinagl
0 siblings, 0 replies; 5+ messages in thread
From: Olliver Schinagl @ 2015-09-21 8:08 UTC (permalink / raw)
To: u-boot
Hey Bin,
On 21-09-15 09:24, Bin Meng wrote:
> Hi Olliver,
>
> On Mon, Sep 21, 2015 at 3:18 PM, Olliver Schinagl
> <o.schinagl@ultimaker.com> wrote:
>> Hey Bin,
>>
>>
>> On 21-09-15 03:50, Bin Meng wrote:
>>> Hi Olliver,
>>>
>>> On Fri, Sep 18, 2015 at 11:29 PM, Olliver Schinagl
>>> <oliver+list@schinagl.nl> wrote:
>>>> From: Olliver Schinagl <o.schinagl@ultimaker.com>
>>>>
>>>> The designware driver has a build guard which makes it to only work when
>>>> using the PHYLIB. With b68fe152272 the PHYLIB was added to the net
>>>> Kconfig but not selected by all hardware depending on it.
>>>>
>>>> This patch enables PHYLIB for the Designware MAC
>>>>
>>>> Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
>>>> ---
>>>> drivers/net/Kconfig | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>>> index bbec6a6..51b1668 100644
>>>> --- a/drivers/net/Kconfig
>>>> +++ b/drivers/net/Kconfig
>>>> @@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
>>>>
>>>> config ETH_DESIGNWARE
>>>> bool "Synopsys Designware Ethernet MAC"
>>>> + select PHYLIB
>>>> help
>>>> This MAC is present in SoCs from various vendors. It supports
>>>> - 100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
>>>> - provide the PHY (physical media interface).
>>>> + 100Mbit and 1 Gbit operation.
>>>>
>>>> config PCH_GBE
>>>> bool "Intel Platform Controller Hub EG20T GMAC driver"
>>>> --
>>> This is not enough. You need update all borads' config.h files to
>>> remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.
>> I was being conservative here,
>>
>> Is it enough to only do the boards that are featured using Kconfig?
> I think all boards have been converted to Kconfig, no?
I'm not sure but will check and work this out.
>
>>>
>>> Regards,
>>> Bin
>>
>> --
>> Met vriendelijke groeten, Kind regards, ??????
> Ah, you know Chinese :-)
Copy paste style yeah ;)
Olliver
>
>> Olliver Schinagl
>> Research & Development
>> Ultimaker B.V.
>>
> Regards,
> Bin
>
> --
> Visit us at
> http://linux-sunxi.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-21 8:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 15:29 [U-Boot] [PATCH 1/1] Kconfig: net: give PHYLIB to designware driver Olliver Schinagl
2015-09-21 1:50 ` Bin Meng
2015-09-21 7:18 ` Olliver Schinagl
2015-09-21 7:24 ` Bin Meng
2015-09-21 8:08 ` Olliver Schinagl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox