public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch v2 03/16] net/fm: Fix the endian issue of ucode uploading to IRAM
Date: Mon, 21 Sep 2015 10:27:05 -0700	[thread overview]
Message-ID: <56003DE9.9060400@freescale.com> (raw)
In-Reply-To: <1442473548-15311-1-git-send-email-Qianyu.Gong@freescale.com>



On 09/17/2015 12:05 AM, Gong Qianyu wrote:
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
> 
> Remove the redundant byte swap of the ucode before uploading to IRAM.
> 
> Signed-off-by: Hou Zhiqiang <B48286@freescale.com>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
> Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
> Signed-off-by: Gong Qianyu <Qianyu.Gong@freescale.com>
> ---
>  drivers/net/fm/eth.c | 69 +++++++++++++++++++++++++++-------------------------
>  drivers/net/fm/fm.c  | 11 +++++----
>  2 files changed, 42 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/net/fm/eth.c b/drivers/net/fm/eth.c
> index 6702f5a..cd05dbc 100644
> --- a/drivers/net/fm/eth.c
> +++ b/drivers/net/fm/eth.c
> @@ -109,7 +109,7 @@ static int tgec_is_fibre(struct eth_device *dev)
>  static u16 muram_readw(u16 *addr)
>  {
>  	u32 base = (u32)addr & ~0x3;
> -	u32 val32 = *(u32 *)base;
> +	u32 val32 = in_be32((u32 *)base);
>  	int byte_pos;
>  	u16 ret;

Reorder this patch with "fix compile warnings for 64-bit platform", or squash
them if possible.

York

      reply	other threads:[~2015-09-21 17:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  7:05 [U-Boot] [Patch v2 03/16] net/fm: Fix the endian issue of ucode uploading to IRAM Gong Qianyu
2015-09-21 17:27 ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56003DE9.9060400@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox