From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] dfu: add SF backend
Date: Mon, 21 Sep 2015 11:31:14 -0600 [thread overview]
Message-ID: <56003EE2.1050805@wwwdotorg.org> (raw)
In-Reply-To: <CAOMZO5D7Up=CTGB-+2=3CesA6gYVn9L=q7qW+RAm8Lk6AFqGpw@mail.gmail.com>
On 09/21/2015 11:13 AM, Fabio Estevam wrote:
> Hi Stephen,
>
> On Wed, Jun 11, 2014 at 7:03 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> This allows SPI Flash to be programmed using DFU.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Is this still working in mainline U-boot?
I haven't tested SF support recently (only MMC). However, it should
still work:-) Are you using ci_udc? If so, make sure you have this very
recent patch:
> commit b337b3b2a53f112a217f4bd31307b02f830bb787
> Author: Stephen Warren <swarren@nvidia.com>
> Date: Fri Sep 11 17:10:02 2015 -0600
>
> usb: ci_udc: fix emissions of ZLPs
>
> Commit 6a132416359e "ci_udc: Update the ci_udc driver to support bulk
> transfers" caused the value of "len" to change without updating subsquent
> users of that variable in ci_ep_submit_next_request(). This caused the
> code that detects when to emit ZLPs (Zero Length Packets) never to
> trigger, which in turn caused host timeouts when a ZLP was required,
> which in turn broke tests/dfu/, even despite the assertion in that
> commit's description that "These changes are tested for both the DFU and
> lthor."
>
> Fix this by modifying the added dtd iteration code not to modify "len",
> but rather to keep state in a separate variable. Rename the variables
> while we're at it so they describe their purpose better.
>
> Fixes: 6a132416359e ("ci_udc: Update the ci_udc driver to support bulk transfers")
> Cc: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2015-09-21 17:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 22:03 [U-Boot] [PATCH 1/4] dfu: defer parsing of device string to IO backend Stephen Warren
2014-06-11 22:03 ` [U-Boot] [PATCH 2/4] dfu: allow backend to specify a maximum buffer size Stephen Warren
2014-06-20 7:54 ` Lukasz Majewski
2014-06-11 22:03 ` [U-Boot] [PATCH 3/4] dfu: add free_entity() to struct dfu_entity Stephen Warren
2014-06-20 7:55 ` Lukasz Majewski
2014-06-11 22:03 ` [U-Boot] [PATCH 4/4] dfu: add SF backend Stephen Warren
2014-06-20 7:55 ` Lukasz Majewski
2015-09-21 17:13 ` Fabio Estevam
2015-09-21 17:31 ` Stephen Warren [this message]
2015-09-21 17:37 ` Fabio Estevam
2015-09-22 1:50 ` Fabio Estevam
2015-09-22 2:55 ` Fabio Estevam
2015-09-22 3:23 ` Stephen Warren
2015-09-22 3:37 ` Fabio Estevam
2015-09-22 7:23 ` Lukasz Majewski
2014-06-20 7:54 ` [U-Boot] [PATCH 1/4] dfu: defer parsing of device string to IO backend Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56003EE2.1050805@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox