From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 21 Sep 2015 11:31:14 -0600 Subject: [U-Boot] [PATCH 4/4] dfu: add SF backend In-Reply-To: References: <1402524216-9999-1-git-send-email-swarren@wwwdotorg.org> <1402524216-9999-4-git-send-email-swarren@wwwdotorg.org> Message-ID: <56003EE2.1050805@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/21/2015 11:13 AM, Fabio Estevam wrote: > Hi Stephen, > > On Wed, Jun 11, 2014 at 7:03 PM, Stephen Warren wrote: >> From: Stephen Warren >> >> This allows SPI Flash to be programmed using DFU. >> >> Signed-off-by: Stephen Warren > > Is this still working in mainline U-boot? I haven't tested SF support recently (only MMC). However, it should still work:-) Are you using ci_udc? If so, make sure you have this very recent patch: > commit b337b3b2a53f112a217f4bd31307b02f830bb787 > Author: Stephen Warren > Date: Fri Sep 11 17:10:02 2015 -0600 > > usb: ci_udc: fix emissions of ZLPs > > Commit 6a132416359e "ci_udc: Update the ci_udc driver to support bulk > transfers" caused the value of "len" to change without updating subsquent > users of that variable in ci_ep_submit_next_request(). This caused the > code that detects when to emit ZLPs (Zero Length Packets) never to > trigger, which in turn caused host timeouts when a ZLP was required, > which in turn broke tests/dfu/, even despite the assertion in that > commit's description that "These changes are tested for both the DFU and > lthor." > > Fix this by modifying the added dtd iteration code not to modify "len", > but rather to keep state in a separate variable. Rename the variables > while we're at it so they describe their purpose better. > > Fixes: 6a132416359e ("ci_udc: Update the ci_udc driver to support bulk transfers") > Cc: Siva Durga Prasad Paladugu > Signed-off-by: Stephen Warren