From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Mon, 21 Sep 2015 21:23:21 -0600 Subject: [U-Boot] [PATCH 4/4] dfu: add SF backend In-Reply-To: References: <1402524216-9999-1-git-send-email-swarren@wwwdotorg.org> <1402524216-9999-4-git-send-email-swarren@wwwdotorg.org> <56003EE2.1050805@wwwdotorg.org> Message-ID: <5600C9A9.7020107@wwwdotorg.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/21/2015 08:55 PM, Fabio Estevam wrote: > On Mon, Sep 21, 2015 at 10:50 PM, Fabio Estevam wrote: >> Stephen, >> >> On Mon, Sep 21, 2015 at 2:37 PM, Fabio Estevam wrote: >>> On Mon, Sep 21, 2015 at 2:31 PM, Stephen Warren wrote: >>> >>>> I haven't tested SF support recently (only MMC). However, it should still >>>> work:-) Are you using ci_udc? If so, make sure you have this very recent >>>> patch: >>>> >>>>> commit b337b3b2a53f112a217f4bd31307b02f830bb787 >>>>> Author: Stephen Warren >>>>> Date: Fri Sep 11 17:10:02 2015 -0600 >>>>> >>>>> usb: ci_udc: fix emissions of ZLPs >>> >>> Yes, I am using ci_udc and this patch is applied. >> >> Do you recall what you used as 'dfu_alt_info' variable when flashing >> SPI via DFU? > > Nevermind. I fixed the issue and will submit the patch shortly. Oh good:-) I was going to give you my dfu_alt_info, but it's at work right now, so I was waiting until tomorrow. I did try to repro this, but I was having a lot of trouble with both the two boards I have that have SPI, so wasn't able to test yet. One thing I did notice: dfu_sf.c's parsing code doesn't work with multiple entries in dfu_alt_info (e.g. for different partitions) since the parsing of the device parameter (to the dfu command; not part of dfu_info) modifies that parameter so it can't be parsed the second time around. Since you're set up to test this, perhaps you could fix it too? I assume all it'd need is to add a strdup()/free() to the start/end of the alt info parsing function?