public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spi : convert altera_spi to driver model
Date: Tue, 22 Sep 2015 11:52:58 +0800	[thread overview]
Message-ID: <5600D09A.2040107@wytron.com.tw> (raw)
In-Reply-To: <201509220210.26908.marex@denx.de>

Hi Marek,

On 09/22/2015 08:10 AM, Marek Vasut wrote:
> I suspect you might want to tweak the core code to check if those
> .set_speed and .set_mode are assigned in dm_spi_ops structure and
> if not, don't call them.

I wonder if this worths, as altera_spi is the only one that cannot set 
speed and mode.

>> +	plat->regs = ioremap(dev_get_addr(bus),
>> +		sizeof(struct altera_spi_regs));
>
> I guess the same thing about ioremap() and ranges applies here?
>

Same thing about ioremap(), as almost every other arch does not include 
it in u-boot. You see that I just added it to nios2 lately.

Sometimes the address returned by dev_get_addr() may be used as memory, 
and does not need ioremap.

Best regards,
Thomas

  reply	other threads:[~2015-09-22  3:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 12:58 [U-Boot] [PATCH] spi : convert altera_spi to driver model Thomas Chou
2015-09-21 18:01 ` Jagan Teki
2015-09-28  0:40   ` Thomas Chou
2015-09-28  8:42     ` Jagan Teki
2015-09-22  0:10 ` Marek Vasut
2015-09-22  3:52   ` Thomas Chou [this message]
2015-09-22  4:13     ` Marek Vasut
2015-09-22  7:45       ` Thomas Chou
2015-09-22  8:11         ` Marek Vasut
2015-09-28 13:27 ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5600D09A.2040107@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox