From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Chou <thomas@wytron.com.tw>
Date: Tue, 22 Sep 2015 11:52:58 +0800
Subject: [U-Boot] [PATCH] spi : convert altera_spi to driver model
In-Reply-To: <201509220210.26908.marex@denx.de>
References: <1442840311-12689-1-git-send-email-thomas@wytron.com.tw>
 <201509220210.26908.marex@denx.de>
Message-ID: <5600D09A.2040107@wytron.com.tw>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On 09/22/2015 08:10 AM, Marek Vasut wrote:
> I suspect you might want to tweak the core code to check if those
> .set_speed and .set_mode are assigned in dm_spi_ops structure and
> if not, don't call them.

I wonder if this worths, as altera_spi is the only one that cannot set 
speed and mode.

>> +	plat->regs = ioremap(dev_get_addr(bus),
>> +		sizeof(struct altera_spi_regs));
>
> I guess the same thing about ioremap() and ranges applies here?
>

Same thing about ioremap(), as almost every other arch does not include 
it in u-boot. You see that I just added it to nios2 lately.

Sometimes the address returned by dev_get_addr() may be used as memory, 
and does not need ioremap.

Best regards,
Thomas