From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Fri, 25 Sep 2015 10:59:41 +0200 Subject: [U-Boot] [PATCH 0/3] Fix fdt 'reg' parsing and unbreak Odroid U3 In-Reply-To: <5604B42D.1080702@samsung.com> References: <1443108590-16871-1-git-send-email-p.marczak@samsung.com> <5604B42D.1080702@samsung.com> Message-ID: <56050CFD.2060401@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Jaehoon, On 09/25/2015 04:40 AM, Jaehoon Chung wrote: > Hi, Przemyslaw. > > On 09/25/2015 12:29 AM, Przemyslaw Marczak wrote: >> Booting of Odroid U3 with SD card, ends with error: >> >> MMC: EXYNOS DWMMC: 0 >> Card did not respond to voltage select! >> *** Warning - MMC init failed, using default environment >> >> Generally this was broken, because of wrong addresses assigned to GPIOs. > > Great! I will check this patch-set..But it seems to look good to me. :) > > Best Regards, > Jaehoon Chung > At present, the patchset was tested on U3/X2 and XU3. >> >> The source of the problem was in rework of lib/fdtdec.c, after which >> function fdtdec_get_addr() doesn't work as previous and function >> dev_get_addr() doesn't works as expected. >> >> The code after rework in lib/fdtdec.c assume, that #size-cells property, >> should be always greater or equal to 1. This was wrong, because it can be 0. >> >> In case of debugging the issue I found, that mmc clock was computed wrong, >> for Exynos4, because of function get_mmc_clk(), which always return -1 for >> this SoC. >> >> Tested on: Odroid U3 and Odroid XU3. >> >> Przemyslaw Marczak (3): >> fix: fdtdec: allow parse 'reg' property with zero value in >> '#size-cells' >> fix: s5p_gpio: call: dev_get_addr() instead of fdtdec_get_addr() >> fix: mach-exynos: clock: restore calling dead exynos4_get_mmc_clk() >> >> arch/arm/mach-exynos/clock.c | 10 ++++------ >> drivers/gpio/s5p_gpio.c | 18 +++++++++++------- >> lib/fdtdec.c | 2 +- >> 3 files changed, 16 insertions(+), 14 deletions(-) >> > > Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com