From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/4] exynos: be more verbose in process_nodes()
Date: Mon, 28 Sep 2015 19:22:11 +0200 [thread overview]
Message-ID: <56097743.50705@samsung.com> (raw)
In-Reply-To: <1443201500-9256-3-git-send-email-tjakobi@math.uni-bielefeld.de>
Hello Tobias,
On 09/25/2015 07:18 PM, Tobias Jakobi wrote:
> In case sdhci_get_config() or do_sdhci_init() fail, show
> the error code that was returned.
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
> drivers/mmc/s5p_sdhci.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c
> index b461fde..b60bc23 100644
> --- a/drivers/mmc/s5p_sdhci.c
> +++ b/drivers/mmc/s5p_sdhci.c
> @@ -171,7 +171,7 @@ static int sdhci_get_config(const void *blob, int node, struct sdhci_host *host)
> static int process_nodes(const void *blob, int node_list[], int count)
> {
> struct sdhci_host *host;
> - int i, node;
> + int i, node, ret;
> int failed = 0;
>
> debug("%s: count = %d\n", __func__, count);
> @@ -184,14 +184,16 @@ static int process_nodes(const void *blob, int node_list[], int count)
>
> host = &sdhci_host[i];
>
> - if (sdhci_get_config(blob, node, host)) {
> - printf("%s: failed to decode dev %d\n", __func__, i);
> + ret = sdhci_get_config(blob, node, host);
> + if (ret) {
> + printf("%s: failed to decode dev %d (%d)\n", __func__, i, ret);
> failed++;
> continue;
> }
>
> - if (do_sdhci_init(host)) {
> - printf("%s: failed to initialize dev %d\n", __func__, i);
> + ret = do_sdhci_init(host);
> + if (ret) {
> + printf("%s: failed to initialize dev %d (%d)\n", __func__, i, ret);
> failed++;
> }
> }
>
Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2015-09-28 17:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 17:18 [U-Boot] [PATCH v2 1/4] exynos: Properly initialize host_caps in s5p_sdhci_core_init() Tobias Jakobi
2015-09-25 17:18 ` [U-Boot] [PATCH v2 2/4] exynos: Fix passing of errors in exynos_mmc_init() Tobias Jakobi
2015-09-28 17:22 ` Przemyslaw Marczak
2015-09-25 17:18 ` [U-Boot] [PATCH v2 3/4] exynos: be more verbose in process_nodes() Tobias Jakobi
2015-09-28 17:22 ` Przemyslaw Marczak [this message]
2015-09-25 17:18 ` [U-Boot] [PATCH v2 4/4] exynos: more debug and cleanup in do_sdhci_init() Tobias Jakobi
2015-09-28 17:22 ` Przemyslaw Marczak
2015-09-28 17:21 ` [U-Boot] [PATCH v2 1/4] exynos: Properly initialize host_caps in s5p_sdhci_core_init() Przemyslaw Marczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56097743.50705@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox