public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/11] Kconfig: add CONFIG_SYS_BOOTM_LEN
Date: Mon, 28 Sep 2015 21:22:35 +0200	[thread overview]
Message-ID: <5609937B.8000309@redhat.com> (raw)
In-Reply-To: <20150928151053.GH22966@bill-the-cat>

Hi,

On 28-09-15 17:10, Tom Rini wrote:
> On Wed, Sep 23, 2015 at 10:25:35AM -0700, Ryan Harkin wrote:
>
>> As config migrates from board config files to Kconfig, when adding
>> CONFIG_SYS_BOOTM_LEN to a platform, I decided to add
>> Kconfig support for CONFIG_SYS_BOOTM_LEN.
>>
>> Signed-off-by: Ryan Harkin <ryan.harkin@linaro.org>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>> CC: Masahiro Yamada <yamada.m@jp.panasonic.com>
>> CC: Simon Glass <sjg@chromium.org>
>> CC: Linus Walleij <linus.walleij@linaro.org>
>
> Thanks for trying to do this.  The problem however is that you need to
> use tools/moveconfig.py so that all of the other boards (which is a lot)
> get updated too, otherwise they fail to build.

No, just no, not more polluting of defconfig files with things which really
belong in a per SoC file not a per board file.

I think we can fix the "make savedefconfig" warnings by doing something like
this in a per SoC Kconfig file:

if ARCH_SUNXI

defconfig SYS_BOOTM_LEN
	default 0x0f000000 if ARCH_SUNXI

endif

The second "if ARCH_SUNXI" is necessary to stop the script calling
"make savedefconfig" for all boards to clean the defconfig files from complaining.

Please let set per SoC defaults this way rather then turning the defconfig
files in a mixture of board / soc settings where as they should really
only select the SoC and then contain board specific settings on top of
that.

Regards,

Hans

  parent reply	other threads:[~2015-09-28 19:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23 17:25 [U-Boot] [PATCH 00/11] vexpress64 FVP and Juno configuration updates Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 01/11] vexpress64: fix checkpatch warnings Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 02/11] vexpress64: Kconfig: tidy up Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 03/11] Kconfig: add CONFIG_SYS_BOOTM_LEN Ryan Harkin
2015-09-28 15:10   ` Tom Rini
2015-09-28 15:35     ` Ryan Harkin
2015-09-28 16:03       ` Tom Rini
2015-09-28 19:22     ` Hans de Goede [this message]
2015-09-28 21:12       ` Tom Rini
2015-09-29  8:38         ` Hans de Goede
2015-09-23 17:25 ` [U-Boot] [PATCH 04/11] vexpress64: " Ryan Harkin
2015-09-28 15:13   ` Tom Rini
2015-09-23 17:25 ` [U-Boot] [PATCH 05/11] vexpress64: fvp dram: add DRAM configuration Ryan Harkin
2015-09-28 15:14   ` Tom Rini
2015-09-28 15:27     ` Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 06/11] vexpress64: juno: add androidboot.hardware=juno Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 07/11] common/armflash: add command to check if image exists Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 08/11] common/armflash: load_image returns success or failure Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 09/11] vexpress64: juno: add optional initrd Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 10/11] vexpress64: juno: add alternate kernel and device tree filenames Ryan Harkin
2015-09-23 17:25 ` [U-Boot] [PATCH 11/11] vexpress64: juno: use /dev/sda2 Ryan Harkin
2015-09-23 17:35 ` [U-Boot] [PATCH 00/11] vexpress64 FVP and Juno configuration updates Ryan Harkin
2015-09-24 16:33 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5609937B.8000309@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox