From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Wed, 30 Sep 2015 09:26:11 +0200 Subject: [U-Boot] [PATCH V2 3/3] mach-exynos: clock: restore calling dead exynos4_get_mmc_clk() In-Reply-To: References: <1443108590-16871-1-git-send-email-p.marczak@samsung.com> <1443442624-7056-1-git-send-email-p.marczak@samsung.com> <1443442624-7056-4-git-send-email-p.marczak@samsung.com> Message-ID: <560B8E93.7060301@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On 09/29/2015 06:47 AM, Simon Glass wrote: > Hi, > > On 28 September 2015 at 06:17, Przemyslaw Marczak wrote: >> After rework of code by: >> >> commit: d952796 Exynos5: Use clock_get_periph_rate generic API >> >> function get_mmc_clk() always returns -1 for Exynos 4. >> >> This was caused by omitting, that SDHCI driver for Exynos 4, >> calls get_mmc_clk(), with mmc device number as argument, >> instead of pinmux peripheral id, like DW MMC driver for Exynos 5. >> >> By this commit, the code directly calls a proper function >> to get mmc clock for Exynos 4, without checking the peripheral id. >> >> Signed-off-by: Przemyslaw Marczak >> --- >> Changes V2: >> - cleanup commit message >> --- >> arch/arm/mach-exynos/clock.c | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) > > I'll pick this up if needed. I tested that it does not break exynos5, > but have not tested it on exynos4. > > Acked-by: Simon Glass > > Regars, > Simon > Thank you for testing. I tested this on Trats2 / Odroid U3 and X2 - all based on Exynos4412. I must only check Trats (Exynos 4210), since Lukasz mentioned about some issue. Anyway I think, that it can be picked up. Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com