public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 05/10] ti: omap3: config: remove 1 from boolean define
Date: Wed, 30 Sep 2015 10:54:37 +0300	[thread overview]
Message-ID: <560B953D.1050302@compulab.co.il> (raw)
In-Reply-To: <20150929171232.GK22966@bill-the-cat>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 09/29/15 20:12, Tom Rini wrote:
> On Tue, Sep 29, 2015 at 07:25:27PM +0300, Igor Grinberg wrote:
> 
>> ping
>>
>> On 09/24/15 12:56, Igor Grinberg wrote:
>>> Hi Tom,
>>>
>>> On 08/26/15 17:54, Igor Grinberg wrote:
>>>> CONFIG_TWL4030_POWER is a boolean define variable. It is either defined
>>>> or not defined and should not have a value assigned to it.
>>>> Remove the value.
>>>>
>>>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>>>
>>> I think this one can also be applied, no?
>>>
>>>> ---
>>>>  include/configs/ti_omap3_common.h | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/configs/ti_omap3_common.h b/include/configs/ti_omap3_common.h
>>>> index be231a5..e399a87 100644
>>>> --- a/include/configs/ti_omap3_common.h
>>>> +++ b/include/configs/ti_omap3_common.h
>>>> @@ -66,7 +66,7 @@
>>>>  #define CONFIG_SYS_MONITOR_LEN		(256 << 10)
>>>>  
>>>>  /* TWL4030 */
>>>> -#define CONFIG_TWL4030_POWER		1
>>>> +#define CONFIG_TWL4030_POWER
>>>>  
>>>>  /* SPL */
>>>>  #define CONFIG_SPL_TEXT_BASE		0x40200800
> 
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> And I figured you just re-post this as part of v2 as it's trivially
> correct but also a tiny thing in a bigger series.

Well, its relation is only by the affected file, so it will help me more
(less things to carry for v2) if you can apply it already.

Thanks!

- -- 
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWC5U9AAoJEBDE8YO64EfaguIP/00wC4X6lL89yIlHpWM6qGZ9
p60KzPvbmfXoa86UyWNrmGBNKkP1i86ECNnRk8CRyzTWKt9f7o9RlceLWfqIYK0G
wkAEk724G+FpYAqgTgkVB/BBF/mimm9JbjdoA5Tx58MDaK3bP5zKQ4J4a1mReZa9
fW/remBNgOtV++QGQBZMzPUWowAc4YQNZ9ZlXN0ZhSqoGprVQAsuQdJybfIIyF+i
GSctjK77ObGpwf7NLS+ft8290f1eo/Jd+KMXFs7m3OHXo+yFvjq9FbET8DGYSy2N
pANLDbxmd3Mgc1PA4XZNnGt6BJ04vNlFhWUW9I2+FZTMldegyblUSc1Fug5mWqWa
DtxgE8YSlEjLbrrgEUlZ6zk6Xmfb5Nz9ndBiNUfduOt3YOUdnR5SJThF7bjq3UXz
LN+fO6K1HK/EY8jc9qMb7Jme4hx1/pHcy4Vzx7Zh/9m4u9mZkRXJnqITxcS2+hhs
H00v3XuhTfjNybgmrunvclPFlxvicb8P7BBTDKhmPzb2mV19g+AhrmmHjIbPhvVh
QBMv0mkQsG+KYqD9ruj+OLT3xMQ99skipX3uUUY3z90u6RGMjRWKvlSrLSmr56SE
AdmnZw6Al/WTLuvi66S3WE3jmjF0f5TKBPa6uIVLyxgdC9jDJZNA1iSDIAX9s5wZ
LDwX8bcLf32c7BPKBe1/
=M25l
-----END PGP SIGNATURE-----

  reply	other threads:[~2015-09-30  7:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-26 14:54 [U-Boot] [PATCH 00/10] Kconfig and ti omap configs tidy up Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 01/10] configs: remove remnants of CONFIG_SYS_NAND_QUIET_TEST Igor Grinberg
2015-08-27  4:53   ` Stefan Roese
2015-09-28 21:07   ` [U-Boot] [U-Boot, " Tom Rini
2015-08-26 14:54 ` [U-Boot] [PATCH 02/10] Kconfig: fix typo in CONFIG_FIT description Igor Grinberg
2015-08-28 17:58   ` Simon Glass
2015-09-28 21:07   ` [U-Boot] [U-Boot, " Tom Rini
2015-08-26 14:54 ` [U-Boot] [PATCH 03/10] Kconfig: add CONFIG_BOOTDELAY Igor Grinberg
2015-08-28 17:58   ` Simon Glass
2015-08-26 14:54 ` [U-Boot] [PATCH 04/10] Kconfig: add CONFIG_CMD_BOOTZ Igor Grinberg
2015-09-24  9:57   ` Igor Grinberg
2015-09-29 16:25     ` Igor Grinberg
2015-09-29 17:11       ` Tom Rini
2015-09-30  7:52         ` Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 05/10] ti: omap3: config: remove 1 from boolean define Igor Grinberg
2015-09-24  9:56   ` Igor Grinberg
2015-09-29 16:25     ` Igor Grinberg
2015-09-29 17:12       ` Tom Rini
2015-09-30  7:54         ` Igor Grinberg [this message]
2015-08-26 14:54 ` [U-Boot] [PATCH 06/10] ti: omap/am: move CONFIG_HUSH_PARSER to defconfig Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 07/10] ti: omap/am: move CONFIG_CMD_BOOTZ " Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 08/10] ti: omap/am: move CONFIG_CMD_NAND " Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 09/10] ti: omap/am: move CONFIG_CMD_I2C " Igor Grinberg
2015-08-26 14:54 ` [U-Boot] [PATCH 10/10] ti: omap/am: move CONFIG_BOOTDELAY " Igor Grinberg
2015-09-24  9:53 ` [U-Boot] [PATCH 00/10] Kconfig and ti omap configs tidy up Igor Grinberg
2015-09-25 17:37   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560B953D.1050302@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox