From: Przemyslaw Marczak <p.marczak@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 0/4] Fix fdt 'reg' parsing and unbreak few Exynos4 boards
Date: Wed, 30 Sep 2015 15:25:25 +0200 [thread overview]
Message-ID: <560BE2C5.1010900@samsung.com> (raw)
In-Reply-To: <20150930131337.GO22966@bill-the-cat>
Hello Tom, Simon,
On 09/30/2015 03:13 PM, Tom Rini wrote:
> On Wed, Sep 30, 2015 at 01:14:49PM +0200, Przemyslaw Marczak wrote:
>
>> Booting of Odroid U3/X2 with SD card, ends with error:
>>
>> MMC: EXYNOS DWMMC: 0
>> Card did not respond to voltage select!
>> *** Warning - MMC init failed, using default environment
>>
>> Generally this was broken, because of wrong addresses,
>> assigned to GPIOs.
>> The source of the problem was in rework of lib/fdtdec.c, after which
>> function fdtdec_get_addr() doesn't work as previous and function
>> dev_get_addr() doesn't works as expected.
>>
>> The code after rework in lib/fdtdec.c assumed, that #size-cells property,
>> should be always greater or equal to 1, this was wrong, because it can be 0.
>>
>> In case of debugging the issue, I found, that mmc clock was computed wrong,
>> for Exynos4, because of function get_mmc_clk(), which always returns -1 for
>> this SoC.
>>
>> The patchset should fix booting on all Exynos4 boards, however it was tested
>> on: Odroid X2 / U3 / XU3 and Trats / Trats2.
>>
>> Przemyslaw Marczak (4):
>> fdtdec: fix parsing 'reg' property with zero value in '#size-cells'
>> gpio: s5p: call: dev_get_addr() instead of fdtdec_get_addr()
>> mach-exynos: clock: restore calling dead exynos4_get_mmc_clk()
>> trats: fdt: disable unused DW MMC
>>
>> arch/arm/dts/exynos4210-trats.dts | 4 ++++
>> arch/arm/mach-exynos/clock.c | 10 ++++------
>> drivers/gpio/s5p_gpio.c | 18 +++++++++++-------
>> lib/fdtdec.c | 2 +-
>> 4 files changed, 20 insertions(+), 14 deletions(-)
>
> Should I grab this directly or expect a PR from the DT or Samsung tree?
> Thanks!
>
If this is not a problem for you, then it will be nice :)
Simon,
Is that good to you?
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
next prev parent reply other threads:[~2015-09-30 13:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 15:29 [U-Boot] [PATCH 0/3] Fix fdt 'reg' parsing and unbreak Odroid U3 Przemyslaw Marczak
2015-09-24 15:29 ` [U-Boot] [PATCH 1/3] fix: fdtdec: allow parse 'reg' property with zero value in '#size-cells' Przemyslaw Marczak
2015-09-24 17:14 ` Stephen Warren
2015-09-25 8:35 ` Przemyslaw Marczak
2015-09-25 15:41 ` Stephen Warren
2015-09-24 15:29 ` [U-Boot] [PATCH 2/3] fix: s5p_gpio: call: dev_get_addr() instead of fdtdec_get_addr() Przemyslaw Marczak
2015-09-24 17:29 ` Stephen Warren
2015-09-25 8:36 ` Przemyslaw Marczak
2015-09-25 15:48 ` Stephen Warren
2015-09-29 4:47 ` Simon Glass
2015-09-24 15:29 ` [U-Boot] [PATCH 3/3] fix: mach-exynos: clock: restore calling dead exynos4_get_mmc_clk() Przemyslaw Marczak
2015-09-25 2:40 ` [U-Boot] [PATCH 0/3] Fix fdt 'reg' parsing and unbreak Odroid U3 Jaehoon Chung
2015-09-25 8:59 ` Przemyslaw Marczak
2015-09-25 8:56 ` Przemyslaw Marczak
2015-09-25 10:15 ` Przemyslaw Marczak
2015-09-28 12:17 ` [U-Boot] [PATCH V2 0/3] Fix fdt 'reg' parsing and unbreak few Exynos4 boards Przemyslaw Marczak
2015-09-28 12:17 ` [U-Boot] [PATCH V2 1/3] fdtdec: fix parsing 'reg' property with zero value in '#size-cells' Przemyslaw Marczak
2015-09-29 4:47 ` Simon Glass
2015-09-30 1:27 ` Minkyu Kang
2015-09-28 12:17 ` [U-Boot] [PATCH V2 2/3] gpio: s5p: call: dev_get_addr() instead of fdtdec_get_addr() Przemyslaw Marczak
2015-09-28 12:17 ` [U-Boot] [PATCH V2 3/3] mach-exynos: clock: restore calling dead exynos4_get_mmc_clk() Przemyslaw Marczak
2015-09-29 4:47 ` Simon Glass
2015-09-30 7:26 ` Przemyslaw Marczak
2015-09-30 8:35 ` Jaehoon Chung
2015-09-30 9:20 ` Przemyslaw Marczak
2015-09-30 11:14 ` [U-Boot] [PATCH V3 0/4] Fix fdt 'reg' parsing and unbreak few Exynos4 boards Przemyslaw Marczak
2015-09-30 11:14 ` [U-Boot] [PATCH V3 1/4] fdtdec: fix parsing 'reg' property with zero value in '#size-cells' Przemyslaw Marczak
2015-10-03 14:28 ` Simon Glass
2015-09-30 11:14 ` [U-Boot] [PATCH V3 2/4] gpio: s5p: call: dev_get_addr() instead of fdtdec_get_addr() Przemyslaw Marczak
2015-10-03 14:44 ` Simon Glass
2015-09-30 11:14 ` [U-Boot] [PATCH V3 3/4] mach-exynos: clock: restore calling dead exynos4_get_mmc_clk() Przemyslaw Marczak
2015-10-03 14:44 ` Simon Glass
2015-09-30 11:14 ` [U-Boot] [PATCH V3 4/4] trats: fdt: disable unused DW MMC Przemyslaw Marczak
2015-10-01 3:37 ` Jaehoon Chung
2015-10-01 7:11 ` Przemyslaw Marczak
2015-10-01 7:22 ` Jaehoon Chung
2015-10-03 14:44 ` Simon Glass
2015-09-30 13:13 ` [U-Boot] [PATCH V3 0/4] Fix fdt 'reg' parsing and unbreak few Exynos4 boards Tom Rini
2015-09-30 13:25 ` Przemyslaw Marczak [this message]
2015-09-30 18:30 ` Simon Glass
2015-10-03 13:36 ` Simon Glass
2015-10-05 7:46 ` Przemyslaw Marczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560BE2C5.1010900@samsung.com \
--to=p.marczak@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox