public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] nios2: convert nios2 cpu to driver model
Date: Thu, 1 Oct 2015 10:14:28 +0800	[thread overview]
Message-ID: <560C9704.9040405@wytron.com.tw> (raw)
In-Reply-To: <CAPnjgZ2Ho4J0hnuTHTcem8h6vVKGcT5Xs18m-7vg800o8RDP4A@mail.gmail.com>

Hi Simon,

On 09/29/2015 10:08 PM, Simon Glass wrote:
>> +       gd->arch.has_mmu = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>> +               "altr,has-mmu", 0);
>
> Should that be fdtdec_get_bool()? Also is there a device tree binding
> file for these settings?

With fdtdec_get_bool(), a boolean properly is true if present in the 
device tree and false if not present, regardless of its value.

It will be wrong if there is "altr,has-mmu = <0>;" .

A dts binding file will be added.

Thanks for your review.

Best regards,
Thomas

  reply	other threads:[~2015-10-01  2:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28  0:31 [U-Boot] [PATCH] nios2: convert nios2 cpu to driver model Thomas Chou
2015-09-29  1:28 ` [U-Boot] [PATCH v2] " Thomas Chou
2015-09-29  2:45   ` Marek Vasut
2015-09-29  7:18     ` Thomas Chou
2015-09-29 14:28       ` Bin Meng
2015-09-29 14:29         ` Bin Meng
2015-09-29 14:52           ` Simon Glass
2015-09-29 12:15 ` [U-Boot] [PATCH v3] " Thomas Chou
2015-09-29 14:08   ` Simon Glass
2015-10-01  2:14     ` Thomas Chou [this message]
2015-10-01  2:31 ` [U-Boot] [PATCH] " Thomas Chou
2015-10-02  7:06   ` Simon Glass
2015-10-04 11:49   ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560C9704.9040405@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox