From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Chou <thomas@wytron.com.tw>
Date: Thu, 1 Oct 2015 10:14:28 +0800
Subject: [U-Boot] [PATCH v3] nios2: convert nios2 cpu to driver model
In-Reply-To: <CAPnjgZ2Ho4J0hnuTHTcem8h6vVKGcT5Xs18m-7vg800o8RDP4A@mail.gmail.com>
References: <1443400318-19151-1-git-send-email-thomas@wytron.com.tw>
 <1443528914-24508-1-git-send-email-thomas@wytron.com.tw>
 <CAPnjgZ2Ho4J0hnuTHTcem8h6vVKGcT5Xs18m-7vg800o8RDP4A@mail.gmail.com>
Message-ID: <560C9704.9040405@wytron.com.tw>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On 09/29/2015 10:08 PM, Simon Glass wrote:
>> +       gd->arch.has_mmu = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
>> +               "altr,has-mmu", 0);
>
> Should that be fdtdec_get_bool()? Also is there a device tree binding
> file for these settings?

With fdtdec_get_bool(), a boolean properly is true if present in the 
device tree and false if not present, regardless of its value.

It will be wrong if there is "altr,has-mmu = <0>;" .

A dts binding file will be added.

Thanks for your review.

Best regards,
Thomas