public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/2] dm: implement a Timer uclass
Date: Thu, 1 Oct 2015 15:22:08 +0800	[thread overview]
Message-ID: <560CDF20.1070808@wytron.com.tw> (raw)
In-Reply-To: <CAPnjgZ2JQmjeOYZnFMFfby1E0rtgPva6AMdzEmkePO0uuoEe0g@mail.gmail.com>

Hi Simon,

On 09/29/2015 09:57 PM, Simon Glass wrote:
>> +int timer_get_count(struct udevice *dev, unsigned long *count);
>
> We should also handle microsecond time in this API. How about:
>
> timer_get_ms()
> timer_get_us()

Please allow the additional API be implemented at some later point. It 
might be better to keep the first patch simple as possible,

>> +       /*
>> +        * Get the timer clock rate
>> +        *
>> +        * @dev:        The Timer device
>> +        * @rate:       pointer that returns the timer clock rate
>> +        */
>> +       int (*get_rate)(struct udevice *dev, unsigned long *rate);
>
> in Hz. Also, isn't the clock rate required to be 1000 now?

Sorry for the confusion. It meant the timer input clock frequency. I 
rename it to get_clock() now. Will this be better?

Thanks a lot for your review.

Best regards,
Thomas Chou

  reply	other threads:[~2015-10-01  7:22 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 13:19 [U-Boot] [PATCH 1/2] dm: implement a Timer uclass Thomas Chou
2015-09-28 13:19 ` [U-Boot] [PATCH 2/2] nios2: convert altera timer to driver model Thomas Chou
2015-09-29  1:32 ` [U-Boot] [PATCH 1/2] dm: implement a Timer uclass Thomas Chou
2015-09-29 12:39 ` [U-Boot] [PATCH v2 " Thomas Chou
2015-09-29 12:39   ` [U-Boot] [PATCH v2 2/2] nios2: convert altera timer to driver model Thomas Chou
2015-09-30  0:27     ` Chin Liang See
2015-10-01  2:51       ` Thomas Chou
2015-10-01  9:12         ` Thomas Chou
2015-09-29 13:57   ` [U-Boot] [PATCH v2 1/2] dm: implement a Timer uclass Simon Glass
2015-10-01  7:22     ` Thomas Chou [this message]
2015-10-03  9:19 ` [U-Boot] [PATCH v3 " Thomas Chou
2015-10-03  9:19   ` [U-Boot] [PATCH v3 2/2] nios2: convert altera timer to driver model Thomas Chou
2015-10-03 14:29   ` [U-Boot] [PATCH v3 1/2] dm: implement a Timer uclass Simon Glass
2015-10-04 13:09     ` Thomas Chou
2015-10-04 13:56 ` [U-Boot] [PATCH v4 " Thomas Chou
2015-10-04 13:56   ` [U-Boot] [PATCH v4 2/2] nios2: convert altera timer to driver model Thomas Chou
2015-10-07  2:27     ` Chin Liang See
2015-10-06 14:14   ` [U-Boot] [PATCH v4 1/2] dm: implement a Timer uclass Simon Glass
2015-10-08  0:55     ` Thomas Chou
2015-10-08  1:03 ` [U-Boot] [PATCH v5 1/3] " Thomas Chou
2015-10-08  1:03   ` [U-Boot] [PATCH v5 2/3] timer: start a new dm_timer after relocation Thomas Chou
2015-10-08 16:09     ` Simon Glass
2015-10-08  1:03   ` [U-Boot] [PATCH v5 3/3] nios2: convert altera timer to driver model Thomas Chou
2015-10-08 17:14   ` [U-Boot] [PATCH v5 1/3] dm: implement a Timer uclass Simon Glass
2015-10-09  1:19     ` Thomas Chou
2015-10-09  1:17 ` [U-Boot] [PATCH v6 " Thomas Chou
2015-10-09  1:17   ` [U-Boot] [PATCH v6 2/3] timer: start a new TIMER after relocation Thomas Chou
2015-10-09  1:32     ` Bin Meng
2015-10-09  5:26       ` Thomas Chou
2015-10-09  1:17   ` [U-Boot] [PATCH v6 3/3] nios2: convert altera timer to driver model Thomas Chou
2015-10-09  9:36   ` [U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass Simon Glass
2015-10-09 10:44     ` Thomas Chou
2015-10-09 10:46       ` Bin Meng
2015-10-09 13:18         ` Thomas Chou
2015-10-09  7:08 ` [U-Boot] [PATCH v7 " Thomas Chou
2015-10-09  7:08   ` [U-Boot] [PATCH v7 2/3] timer: start a new dm_timer after relocation Thomas Chou
2015-10-09  7:08   ` [U-Boot] [PATCH v7 3/3] nios2: convert altera timer to driver model Thomas Chou
2015-10-10  7:16 ` [U-Boot] [PATCH v8 1/3] dm: implement a Timer uclass Thomas Chou
2015-10-10  7:16   ` [U-Boot] [PATCH v8 2/3] timer: start a new timer after relocation Thomas Chou
2015-10-13 13:17     ` Thomas Chou
2015-10-10  7:16   ` [U-Boot] [PATCH v8 3/3] nios2: convert altera timer to driver model Thomas Chou
2015-10-13 13:17     ` Thomas Chou
2015-10-13 13:17   ` [U-Boot] [PATCH v8 1/3] dm: implement a Timer uclass Thomas Chou
2015-10-19  1:53     ` Simon Glass
2015-10-19 10:54       ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560CDF20.1070808@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox