[U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer

[Jacob Stiffler <j-stiffler@ti.com>]

On 10/1/2015 10:27 AM, Wolfgang Denk wrote:
> Dear Jacob,
>
> In message <1443622325-30792-1-git-send-email-j-stiffler@ti.com> you wrote:
>> The net_boot_file_name buffer is used as storage for the bootfilename
>> command line argument to network boot commands such as tftp and nfs.
>>
>> Increase the size of this buffer to 1024 bytes as the current size of
>> 128 bytes is restrictive for arbitrary paths on the server.
> According to RFC 2131, the boot file name has a fixed size of 128
> octets.

Wolfgang,

Yes. However, the global "net_boot_file_name" is not only used for 
BOOTP, but also for NFS and TFTP.

"net_boot_file_name" appears to be temporary storage to supply the file 
path to arbitrary protocols from the command line arguments.

The "file" field in the bootp message is fixed at 128 octets in the 
"bootp_hdr" structure.

The contents of "net_boot_file_name" are read or written using the 
standard "strncopy()" or the similar "copy_filename()", so there should 
be any issue with respect to memory leaks.

Thank you,
Jacob Stiffler

> Best regards,
>
> Wolfgang Denk
>