From: Sinan Akman <sinan@writeme.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "imx: wdog: correct wcr register settings"
Date: Thu, 1 Oct 2015 15:50:51 -0400 [thread overview]
Message-ID: <560D8E9B.6000207@writeme.com> (raw)
In-Reply-To: <CAOMZO5Dhy2a_fFdBQJ8vaeHURqWD+z4M5n4BqjQiOEDvtkG9FA@mail.gmail.com>
On 01/10/15 03:45 PM, Fabio Estevam wrote:
> Hi Sinan,
>
> On Thu, Oct 1, 2015 at 4:39 PM, Sinan Akman <sinan@writeme.com> wrote:
>
>> Hi Fabio, I just wanted to point out that with this revert we don't only
>> break imx again
> We are not breaking imx by doing the revert. The reset still works.
> 623d96e89aca64c2 appeared only in 2015.10-rc4.
>
>> (whatever the initial bug was for this commit) but also we are having
>> ls1021atwr
>> working accidentally, just because writew(WCR_WDE, &wdog->wcr) clears SRS
>> bit which is the only requirement for reset if watchdog is not running.
>>
>> I don't have any strong opinion on this but i just wanted to make it clear
>> that
>> we are leaving both imx6 and ls1021atwr not properly implemented.
> I think it is the best/safest we can do at -rc4 to avoid the reset
> regression on ls1021.
>
> Then a proper implementation can be done for 2016.01.
>
> Do you agree?
Hi Fabio, yes this seems to be the best thing to do for now.
Let's implement then this thing properly soon after.
Thanks
Sinan Akman
next prev parent reply other threads:[~2015-10-01 19:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 19:32 [U-Boot] [PATCH] Revert "imx: wdog: correct wcr register settings" Fabio Estevam
2015-10-01 19:39 ` Sinan Akman
2015-10-01 19:45 ` Fabio Estevam
2015-10-01 19:50 ` Sinan Akman [this message]
2015-10-01 19:52 ` Fabio Estevam
2015-10-01 20:11 ` Wolfgang Denk
2015-10-01 20:19 ` Fabio Estevam
2015-10-01 20:50 ` Wolfgang Denk
2015-10-01 23:11 ` Fabio Estevam
2015-10-02 1:48 ` Sinan Akman
2015-10-02 4:30 ` Wolfgang Denk
2015-10-02 11:10 ` Fabio Estevam
2015-10-02 11:39 ` Fabio Estevam
2015-10-02 13:04 ` Sinan Akman
2015-10-02 13:29 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D8E9B.6000207@writeme.com \
--to=sinan@writeme.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox