public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jacob Stiffler <j-stiffler@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
Date: Thu, 1 Oct 2015 16:11:10 -0400	[thread overview]
Message-ID: <560D935E.5090803@ti.com> (raw)
In-Reply-To: <20151001200738.73882382C34@gemini.denx.de>



On 10/1/2015 4:07 PM, Wolfgang Denk wrote:
> Dear Jacob,
>
> In message <560D6DE3.8070901@ti.com> you wrote:
>> Yes. However, the global "net_boot_file_name" is not only used for
>> BOOTP, but also for NFS and TFTP.
>>
>> "net_boot_file_name" appears to be temporary storage to supply the file
>> path to arbitrary protocols from the command line arguments.
> I see.
>
>> The "file" field in the bootp message is fixed at 128 octets in the
>> "bootp_hdr" structure.
>>
>> The contents of "net_boot_file_name" are read or written using the
>> standard "strncopy()" or the similar "copy_filename()", so there should
>> be any issue with respect to memory leaks.
> I guess you mean there should NOT be any issue?

Yes, sorry. There should not be any issue with respect to memory leaks.

Thank you,
Jacob Stiffler

> Best regards,
>
> Wolfgang Denk
>

  reply	other threads:[~2015-10-01 20:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 14:12 [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer Jacob Stiffler
2015-10-01 14:27 ` Wolfgang Denk
2015-10-01 17:31   ` Jacob Stiffler
2015-10-01 20:07     ` Wolfgang Denk
2015-10-01 20:11       ` Jacob Stiffler [this message]
2015-10-06 17:26         ` Jacob Stiffler
2015-10-03 14:13   ` Stefan Bruens
2015-10-03 14:41     ` Otavio Salvador
2015-10-28 20:09 ` Joe Hershberger
2015-10-29 19:33 ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560D935E.5090803@ti.com \
    --to=j-stiffler@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox