From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Stiffler Date: Thu, 1 Oct 2015 16:11:10 -0400 Subject: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer In-Reply-To: <20151001200738.73882382C34@gemini.denx.de> References: <1443622325-30792-1-git-send-email-j-stiffler@ti.com> <20151001142711.1CB7B3822C0@gemini.denx.de> <560D6DE3.8070901@ti.com> <20151001200738.73882382C34@gemini.denx.de> Message-ID: <560D935E.5090803@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/1/2015 4:07 PM, Wolfgang Denk wrote: > Dear Jacob, > > In message <560D6DE3.8070901@ti.com> you wrote: >> Yes. However, the global "net_boot_file_name" is not only used for >> BOOTP, but also for NFS and TFTP. >> >> "net_boot_file_name" appears to be temporary storage to supply the file >> path to arbitrary protocols from the command line arguments. > I see. > >> The "file" field in the bootp message is fixed at 128 octets in the >> "bootp_hdr" structure. >> >> The contents of "net_boot_file_name" are read or written using the >> standard "strncopy()" or the similar "copy_filename()", so there should >> be any issue with respect to memory leaks. > I guess you mean there should NOT be any issue? Yes, sorry. There should not be any issue with respect to memory leaks. Thank you, Jacob Stiffler > Best regards, > > Wolfgang Denk >