public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 00/11] imx: mx6: support lcdif
Date: Fri, 2 Oct 2015 10:48:21 +0200	[thread overview]
Message-ID: <560E44D5.5000604@denx.de> (raw)
In-Reply-To: <1441880948-18201-1-git-send-email-Peng.Fan@freescale.com>

Hi Peng,

I have not forgotten this series. Anyway, this has introduced aome
changes that could brick other boards and it is my opininio to postpone
it after 2015.10 release. Of course, I will send to you a full review
for that.

Best regards,
Stefano Babic


On 10/09/2015 12:28, Peng Fan wrote:
> This patch set is to introduce lcdif support for i.MX6.
> 
> Now only i.MX6UL support is in this patchset.
> Patchset tested on mx6ul_14x14_evk and mx6ul_9x9_evk
> (needs 9x9 SPL patch applied).
> 
> 1/11
> There are two LCD interface for i.MX6SX and one interface for i.MX6UL,
> so change the prototype mxs_set_lcdclk to handle different interface.
> 
> [2,3]/11
> I am not sure, but from my understanding, the 'board_' should be discarded.
> 
> 4/11
> mx28 and mx6ul/sx have similar register layout and bit definitions, so
> move related structure and bit definitions to imx-common.
> 
> [5,6,7]/11
> is to add related CCM macros, clock apis for enable lcdif on i.MX6
> 
> 8/11
> support lcdif for i.MX6UL 14x14/9x9 board
> 
> 9/11
> Introduce lcdif_power_down, to make system stable when reset or boot os
> 
> [10,11]/11
> Need to call lcdif_power_down, before trigger wdog reset or boot os.
> Or we may met unexpected system hang.
> 
> Peng Fan (11):
>   mxs: add parameter base_addr for mxs_set_lcdclk
>   sandisk: sfp: correct function name
>   xfi3: correct function name
>   imx: imx-common: move lcdif structure and macro definition to
>     imx-common
>   imx: mx6: fix register address
>   imx: mx6: crm_reg: add LCDIF related macros
>   imx: mx6: add clock api for lcdif
>   imx: mx6ul_14x14_evk: support lcdif display
>   video: mxsfb: introduce lcdif_power_down
>   imx: mx6: implement reset_misc
>   imx: imx-common: power down lcdif before boot os
> 
>  arch/arm/cpu/arm926ejs/mxs/clock.c                |   2 +-
>  arch/arm/cpu/armv7/mx6/clock.c                    | 239 ++++++++++++++++++++++
>  arch/arm/cpu/armv7/mx6/soc.c                      |   8 +
>  arch/arm/imx-common/cpu.c                         |   3 +
>  arch/arm/include/asm/arch-mx6/clock.h             |   2 +
>  arch/arm/include/asm/arch-mx6/crm_regs.h          |  34 ++-
>  arch/arm/include/asm/arch-mx6/imx-regs.h          |  15 +-
>  arch/arm/include/asm/arch-mxs/clock.h             |   2 +-
>  arch/arm/include/asm/arch-mxs/regs-lcdif.h        | 201 +-----------------
>  arch/arm/include/asm/imx-common/regs-lcdif.h      | 222 ++++++++++++++++++++
>  arch/arm/include/asm/imx-common/sys_proto.h       |   2 +
>  board/creative/xfi3/xfi3.c                        |   2 +-
>  board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c |  63 ++++++
>  board/sandisk/sansa_fuze_plus/sfp.c               |   2 +-
>  drivers/video/mxsfb.c                             |  19 +-
>  include/configs/mx6ul_14x14_evk.h                 |  18 ++
>  16 files changed, 620 insertions(+), 214 deletions(-)
>  create mode 100644 arch/arm/include/asm/imx-common/regs-lcdif.h
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2015-10-02  8:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 10:28 [U-Boot] [PATCH 00/11] imx: mx6: support lcdif Peng Fan
2015-09-10 10:28 ` [U-Boot] [PATCH 01/11] mxs: add parameter base_addr for mxs_set_lcdclk Peng Fan
2015-09-10 10:28 ` [U-Boot] [PATCH 02/11] sandisk: sfp: correct function name Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 03/11] xfi3: " Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 04/11] imx: imx-common: move lcdif structure and macro definition to imx-common Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 05/11] imx: mx6: fix register address Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 06/11] imx: mx6: crm_reg: add LCDIF related macros Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 07/11] imx: mx6: add clock api for lcdif Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 08/11] imx: mx6ul_14x14_evk: support lcdif display Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 09/11] video: mxsfb: introduce lcdif_power_down Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 10/11] imx: mx6: implement reset_misc Peng Fan
2015-09-10 10:29 ` [U-Boot] [PATCH 11/11] imx: imx-common: power down lcdif before boot os Peng Fan
2015-10-02  8:48 ` Stefano Babic [this message]
2015-10-20  9:19   ` [U-Boot] [PATCH 00/11] imx: mx6: support lcdif Peng Fan
2015-10-20 10:35     ` Peng Fan
2015-10-20 11:47       ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560E44D5.5000604@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox