public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: Jonas Karlman <jonas@kwiboo.se>, Simon Glass <sjg@chromium.org>,
	Philipp Tomsich <philipp.tomsich@vrull.eu>,
	Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 07/11] rockchip: rk3288-firefly: Drop use of silent console and late boardinfo
Date: Fri, 3 Jan 2025 14:41:18 +0800	[thread overview]
Message-ID: <560baffe-fe1e-4eee-97bb-adcd5be9674b@rock-chips.com> (raw)
In-Reply-To: <20241212221000.94501-8-jonas@kwiboo.se>


On 2024/12/13 06:09, Jonas Karlman wrote:
> Current use of SILENT_CONSOLE hide valuable information when something
> goes wrong during boot, drop this Kconfig option to allow user to see
> e.g. from what media U-Boot proper is loaded from.
>
> A second Model line is printed on console due to DISPLAY_BOARDINFO_LATE,
> drop this Kconfig option to remove the second redundant line.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   configs/firefly-rk3288_defconfig | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/configs/firefly-rk3288_defconfig b/configs/firefly-rk3288_defconfig
> index 2160474fe0f3..6e395f5c450d 100644
> --- a/configs/firefly-rk3288_defconfig
> +++ b/configs/firefly-rk3288_defconfig
> @@ -20,8 +20,6 @@ CONFIG_DEBUG_UART=y
>   # CONFIG_ANDROID_BOOT_IMAGE is not set
>   CONFIG_USE_PREBOOT=y
>   CONFIG_DEFAULT_FDT_FILE="rk3288-firefly.dtb"
> -CONFIG_SILENT_CONSOLE=y
> -CONFIG_DISPLAY_BOARDINFO_LATE=y
>   CONFIG_MISC_INIT_R=y
>   CONFIG_SPL_PAD_TO=0x7f8000
>   CONFIG_CMD_GPIO=y

  reply	other threads:[~2025-01-03  6:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 22:09 [PATCH 00/11] rockchip: rk3288-firefly: Migrate to OF_UPSTREAM Jonas Karlman
2024-12-12 22:09 ` [PATCH 01/11] rockchip: rk3288-firefly: Drop unused SPL_LED related code Jonas Karlman
2025-01-03  6:39   ` Kever Yang
2024-12-12 22:09 ` [PATCH 02/11] rockchip: rk3288-firefly: Sort u-boot.dtsi nodes alphabetically Jonas Karlman
2025-01-03  6:39   ` Kever Yang
2024-12-12 22:09 ` [PATCH 03/11] rockchip: rk3288-firefly: Set ethaddr env based on cpuid Jonas Karlman
2025-01-03  6:39   ` Kever Yang
2024-12-12 22:09 ` [PATCH 04/11] rockchip: rk3288-firefly: Use common bss and stack addresses Jonas Karlman
2025-01-03  6:39   ` Kever Yang
2024-12-12 22:09 ` [PATCH 05/11] rockchip: rk3288-firefly: Include required DT nodes in xPL Jonas Karlman
2025-01-03  6:40   ` Kever Yang
2024-12-12 22:09 ` [PATCH 06/11] rockchip: rk3288-firefly: Include sdmmc regulator in SPL Jonas Karlman
2025-01-03  6:41   ` Kever Yang
2024-12-12 22:09 ` [PATCH 07/11] rockchip: rk3288-firefly: Drop use of silent console and late boardinfo Jonas Karlman
2025-01-03  6:41   ` Kever Yang [this message]
2024-12-12 22:09 ` [PATCH 08/11] rockchip: rk3288-firefly: Drop USE_PREBOOT Kconfig option Jonas Karlman
2025-01-03  6:41   ` Kever Yang
2024-12-12 22:09 ` [PATCH 09/11] rockchip: rk3288-firefly: Migrate to OF_UPSTREAM Jonas Karlman
2025-01-03  6:41   ` Kever Yang
2024-12-12 22:09 ` [PATCH 10/11] rockchip: rk3288-firefly: Fix slow Ethernet initializion Jonas Karlman
2025-01-03  6:42   ` Kever Yang
2024-12-12 22:09 ` [PATCH 11/11] rockchip: rk3288-firefly: Change to use FIT Jonas Karlman
2025-01-03  6:41   ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560baffe-fe1e-4eee-97bb-adcd5be9674b@rock-chips.com \
    --to=kever.yang@rock-chips.com \
    --cc=jonas@kwiboo.se \
    --cc=philipp.tomsich@vrull.eu \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox