From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86DBDC433EF for ; Thu, 9 Dec 2021 19:55:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CDBFA830C5; Thu, 9 Dec 2021 20:55:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Y+iTIjRA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0CE8C83230; Thu, 9 Dec 2021 20:55:20 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 21BB482F03 for ; Thu, 9 Dec 2021 20:55:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1639079713; bh=bab93aXVCZ8UhIE1JplDXsoydzuvtlm5rvnQ2XJVKcE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Y+iTIjRAyb9qaOHwcTgFvFSB4geHu1uhla1UMjuuyK3rEdHBHHOy6DlPsLfEkzbO9 5CTtn94DsGPQLHc5F63Q3R7D0f6U4zmDDjiTEGEqbp4o/8eFBeOF0Ub034irObric3 r/J03nZk5/eg3205hfaP/CkKbQVCLupZ/wapOAZY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [172.31.56.117] ([216.9.110.2]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N49hB-1mVOEL1hkP-0102wq; Thu, 09 Dec 2021 20:55:12 +0100 Message-ID: <560e2401-9866-b396-c8bb-d166a75e1429@gmx.de> Date: Thu, 9 Dec 2021 11:55:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v5 18/28] efi: Show when allocated pages are used Content-Language: en-US To: Simon Glass Cc: Ilias Apalodimas , Christian Melki , Bin Meng , Tom Rini , Alexander Graf , U-Boot Mailing List References: <20211204155657.2913911-1-sjg@chromium.org> <20211204085647.v5.18.I2eff1cd4f12753d0d86e9751fa350458ef5789e0@changeid> From: Heinrich Schuchardt In-Reply-To: <20211204085647.v5.18.I2eff1cd4f12753d0d86e9751fa350458ef5789e0@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:J57FpcDrQZXAjDQRTzrzekWPCYf40NNK83+1AdX6Ytj0hgRVZsP 1wOyGT+8XZqZc0KHmXxBF2VUhk+ViQPkG7GJxKF3QvH3/O3fKbmIMkV1zroqBzxeZ31r3LW D3t6Ml9jFUCqddl5J4Ppq6wjvKJ9hbUao/NjShP5Tx/gKAMmeXhmf2f09YgolBkFb2pMrR3 Ab7faEPU1YNUsKChyk0kg== X-UI-Out-Filterresults: notjunk:1;V03:K0:s1K3nSiunoo=:yNjP2dWmt3uwcxk41kAmyH U/imJkAYB0OMEjGFjcr1pZ8N3srNAIB/3Ttgk3jPe1of3HHU95sae7KOMHkFQu1mM1ClVD4D6 T7Y/ye68bbj5v0RG+06rheVWFlnHefG/u0CJTj8ms8Q47JKfdHt35bmRNFbHW2qBEy88+eEBn BScQyfoIMtWWv0eBN/m4QgDpn87J1IvJ6YEnmDlpvGAN9pF8CXgz3LxBd6sIGYQ1vk1iwtQXP C7o23MBZ0vRXXDVykeGhUL8THb4jvUEp/fDekruKXPcV3SL4EY/vLSzp14uAFAt/OY8GAI2lr fBzniYqrMmdEi+M8NTMkRlZR7db27pvOXhWoeAYs9eIBWuQMCRrHiQVSa3JFYKALUdNE2We+v UjXABIeiCFZnOwdPtYLQg8Lc5gYlZPjRElQsICqBralw0cT+ARPxK7e5uVh3SUmCr2Lf1AAo6 v2SJsLI3fKS5zJNZ7sKa8Eo92KUWCFcstq4itZA2wq9gxpFth/id1JJFJsfbDjGqoYYFaWuTH 6aCBSiqPM0wy+mgUAT7HcQTaeKM5KxUmbB25T7XTSM7xbivin/6m/OtkklpbTOUr3w/4OaCWa 9kDemlFXkdW/fXhc+Wr4x6XWOXsMKJgcLYYRrRAKVd8hFdGAqPH6njowwd2fmZUwiYewBFwcQ ye/eWWnm1HlhqsTr1EdeXcK/OzW4ilB9LPX5hdoKa8lesIkaAgNrJfKjnpPF/Q2OEzWEPA/PN V8S8C0mAdS2qDz1RFQ22IjegBvai58zux+mV0yc5QLOkNBNPk86Z/FKZFf12MjINlOcImxWTG TAJ/8kC8ddokWJnTIzf9oJZLfAn9Kiu9k2tWRQ0PL0S3+sH2itsUB/ww39SQZi1CCesNNBm1v WolQuM29gcTNRETStal03EKr5qprGQlc/UrGPhA0+k6PkiDi4pn1wraCHy+jfW9h70++b4ezu Mdwsmven7Sjq0bzuNvKketGnoWIAcD2jSUt4b9G6fKdJYqfLH8DWNxbzq6RsMQCYGfANqZiuJ F+umqJb6zR0/6ki+vBCSuAZGas5cUQmXXDiAozjteSImOfOfRer8DQEM/QH5CpuWRblMUKCdW pouuEsyF+Yv3Ak= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/4/21 07:56, Simon Glass wrote: > Add a message here so that both paths of memory allocation are reported. > > Signed-off-by: Simon Glass > --- > > (no changes since v2) > > Changes in v2: > - Use log_info() instead of printf() > > lib/efi/efi_app.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/efi/efi_app.c b/lib/efi/efi_app.c > index e454f1a1564..36e3f1de427 100644 > --- a/lib/efi/efi_app.c > +++ b/lib/efi/efi_app.c > @@ -121,13 +121,14 @@ static efi_status_t setup_memory(struct efi_priv *= priv) > ret =3D boot->allocate_pages(EFI_ALLOCATE_MAX_ADDRESS, > priv->image_data_type, pages, &addr); > if (ret) { If AllocatePages() fails the system is out of memory. Just return to the calling firmware with EFI_OUT_OF_RESOURCES. Best regards Heinrich > - printf("(using pool %lx) ", ret); > + log_info("(using pool %lx) ", ret); > priv->ram_base =3D (ulong)efi_malloc(priv, CONFIG_EFI_RAM_SIZE, > &ret); > if (!priv->ram_base) > return ret; > priv->use_pool_for_malloc =3D true; > } else { > + log_info("(using allocated RAM address %lx) ", (ulong)addr); > priv->ram_base =3D addr; > } > gd->ram_size =3D pages << 12; >