From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Sat, 3 Oct 2015 22:16:03 +0200 Subject: [U-Boot] [PATCH 3/7] sunxi: power: Unify axp pmic function names In-Reply-To: References: <1443882383-21181-1-git-send-email-hdegoede@redhat.com> <1443882383-21181-3-git-send-email-hdegoede@redhat.com> Message-ID: <56103783.2090105@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 03-10-15 16:32, Chen-Yu Tsai wrote: > On Sat, Oct 3, 2015 at 10:26 PM, Hans de Goede wrote: >> Stop prefixing the axp functions for setting voltages, etc. with the >> model number, there ever is only one pmic driver built into u-boot, >> this allows simplifying the callers. > > Hmm... What's going to happen with the A80, which has 2 PMICs? IIRC > a subset of their LDOs share the same name, which would be a problem. My plan for that is to use a different function name for the ldo-s on the secondary pmic, e.g. something like axp2_set_xldo1(...), or somesuch. Actually this patch should help adding support for the other pmics since it will make it less of an #ifdef fest. Regards, Hans