From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Mon, 05 Oct 2015 09:46:28 +0200 Subject: [U-Boot] [PATCH V3 0/4] Fix fdt 'reg' parsing and unbreak few Exynos4 boards In-Reply-To: References: <1443442624-7056-1-git-send-email-p.marczak@samsung.com> <1443611693-23722-1-git-send-email-p.marczak@samsung.com> <20150930131337.GO22966@bill-the-cat> <560BE2C5.1010900@samsung.com> Message-ID: <56122AD4.50705@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 10/03/2015 03:36 PM, Simon Glass wrote: > Hi, > > On 30 September 2015 at 19:30, Simon Glass wrote: >> Hi Przemyslaw, >> >> On 30 September 2015 at 06:25, Przemyslaw Marczak wrote: >>> Hello Tom, Simon, >>> >>> >>> On 09/30/2015 03:13 PM, Tom Rini wrote: >>>> >>>> On Wed, Sep 30, 2015 at 01:14:49PM +0200, Przemyslaw Marczak wrote: >>>> >>>>> Booting of Odroid U3/X2 with SD card, ends with error: >>>>> >>>>> MMC: EXYNOS DWMMC: 0 >>>>> Card did not respond to voltage select! >>>>> *** Warning - MMC init failed, using default environment >>>>> >>>>> Generally this was broken, because of wrong addresses, >>>>> assigned to GPIOs. >>>>> The source of the problem was in rework of lib/fdtdec.c, after which >>>>> function fdtdec_get_addr() doesn't work as previous and function >>>>> dev_get_addr() doesn't works as expected. >>>>> >>>>> The code after rework in lib/fdtdec.c assumed, that #size-cells property, >>>>> should be always greater or equal to 1, this was wrong, because it can be >>>>> 0. >>>>> >>>>> In case of debugging the issue, I found, that mmc clock was computed >>>>> wrong, >>>>> for Exynos4, because of function get_mmc_clk(), which always returns -1 >>>>> for >>>>> this SoC. >>>>> >>>>> The patchset should fix booting on all Exynos4 boards, however it was >>>>> tested >>>>> on: Odroid X2 / U3 / XU3 and Trats / Trats2. >>>>> >>>>> Przemyslaw Marczak (4): >>>>> fdtdec: fix parsing 'reg' property with zero value in '#size-cells' >>>>> gpio: s5p: call: dev_get_addr() instead of fdtdec_get_addr() >>>>> mach-exynos: clock: restore calling dead exynos4_get_mmc_clk() >>>>> trats: fdt: disable unused DW MMC >>>>> >>>>> arch/arm/dts/exynos4210-trats.dts | 4 ++++ >>>>> arch/arm/mach-exynos/clock.c | 10 ++++------ >>>>> drivers/gpio/s5p_gpio.c | 18 +++++++++++------- >>>>> lib/fdtdec.c | 2 +- >>>>> 4 files changed, 20 insertions(+), 14 deletions(-) >>>> >>>> >>>> Should I grab this directly or expect a PR from the DT or Samsung tree? >>>> Thanks! >>>> >>> >>> If this is not a problem for you, then it will be nice :) >>> >>> Simon, >>> Is that good to you? >> >> Yes, thank you both. > > Hmm I'm going to pick this up for the DT tree as there's another patch > needed from Stephen also. Tom if you already have this locally let me > know. > > Regards, > Simon > Ok, thanks. Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com