public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jacob Stiffler <j-stiffler@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer
Date: Tue, 6 Oct 2015 13:26:10 -0400	[thread overview]
Message-ID: <56140432.9020004@ti.com> (raw)
In-Reply-To: <560D935E.5090803@ti.com>

> On Sat, Oct 3, 2015 at 11:13 AM, Stefan Bruens
> <stefan.bruens@rwth-aachen.de> wrote:
> > On Thursday 01 October 2015 16:27:11 Wolfgang Denk wrote:
> >> Dear Jacob,
> >>
> >> In message <1443622325-30792-1-git-send-email-j-stiffler@ti.com> you wrote:
> >> > The net_boot_file_name buffer is used as storage for the bootfilename
> >> > command line argument to network boot commands such as tftp and nfs.
> >> >
> >> > Increase the size of this buffer to 1024 bytes as the current size of
> >> > 128 bytes is restrictive for arbitrary paths on the server.
> >>
> >> According to RFC 2131, the boot file name has a fixed size of 128
> >> octets.
> >
> > You can also put the file name into Option 67, which results in a length limit
> > of 255 octets (DHCP option length limit).
> >
> > I sent patches with several DHCP enhancements, including Option 67 support, to
> > the ML a few weeks ago.
>
> Has those patches been applied? otherwise it would be good to rebase
> it and send them again as we are close of release and merge window
> will soon open.
The intent of this patch is not to increase the size of the path for bootp, but to
increase the size of the path for nfs and tftp. The "net_boot_file_name" is a common
global variable used for all network commands which load files into memory, and is
basically temporary storage.

  reply	other threads:[~2015-10-06 17:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30 14:12 [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer Jacob Stiffler
2015-10-01 14:27 ` Wolfgang Denk
2015-10-01 17:31   ` Jacob Stiffler
2015-10-01 20:07     ` Wolfgang Denk
2015-10-01 20:11       ` Jacob Stiffler
2015-10-06 17:26         ` Jacob Stiffler [this message]
2015-10-03 14:13   ` Stefan Bruens
2015-10-03 14:41     ` Otavio Salvador
2015-10-28 20:09 ` Joe Hershberger
2015-10-29 19:33 ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56140432.9020004@ti.com \
    --to=j-stiffler@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox