From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacob Stiffler Date: Tue, 6 Oct 2015 13:26:10 -0400 Subject: [U-Boot] [PATCH] net: Increase the size of the net_boot_file_name buffer In-Reply-To: <560D935E.5090803@ti.com> References: <1443622325-30792-1-git-send-email-j-stiffler@ti.com> <20151001142711.1CB7B3822C0@gemini.denx.de> <560D6DE3.8070901@ti.com> <20151001200738.73882382C34@gemini.denx.de> <560D935E.5090803@ti.com> Message-ID: <56140432.9020004@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On Sat, Oct 3, 2015 at 11:13 AM, Stefan Bruens > wrote: > > On Thursday 01 October 2015 16:27:11 Wolfgang Denk wrote: > >> Dear Jacob, > >> > >> In message <1443622325-30792-1-git-send-email-j-stiffler@ti.com> you wrote: > >> > The net_boot_file_name buffer is used as storage for the bootfilename > >> > command line argument to network boot commands such as tftp and nfs. > >> > > >> > Increase the size of this buffer to 1024 bytes as the current size of > >> > 128 bytes is restrictive for arbitrary paths on the server. > >> > >> According to RFC 2131, the boot file name has a fixed size of 128 > >> octets. > > > > You can also put the file name into Option 67, which results in a length limit > > of 255 octets (DHCP option length limit). > > > > I sent patches with several DHCP enhancements, including Option 67 support, to > > the ML a few weeks ago. > > Has those patches been applied? otherwise it would be good to rebase > it and send them again as we are close of release and merge window > will soon open. The intent of this patch is not to increase the size of the path for bootp, but to increase the size of the path for nfs and tftp. The "net_boot_file_name" is a common global variable used for all network commands which load files into memory, and is basically temporary storage.