[U-Boot] [PATCH] omap3: cm-t3517: add board specific get_board_rev()

[U-Boot] [PATCH] omap3: cm-t3517: add board specific get_board_rev()

[Dmitry Lifshitz]

CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
---
 board/compulab/cm_t3517/cm_t3517.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/board/compulab/cm_t3517/cm_t3517.c b/board/compulab/cm_t3517/cm_t3517.c
index 03b2bad..bf7dec2 100644
--- a/board/compulab/cm_t3517/cm_t3517.c
+++ b/board/compulab/cm_t3517/cm_t3517.c
@@ -98,6 +98,15 @@ int board_init(void)
 	return 0;
 }
 
+/*
+ * Routine: get_board_rev
+ * Description: read system revision
+ */
+u32 get_board_rev(void)
+{
+	return cl_eeprom_get_board_rev();
+};
+
 int misc_init_r(void)
 {
 	cl_print_pcb_info();
-- 
1.7.5.4

[U-Boot] [PATCH] omap3: cm-t3517: add board specific get_board_rev()

[Igor Grinberg]

Hi Dima,

On 10/08/15 14:20, Dmitry Lifshitz wrote:
> CM-T3517 has several HW revisions.
> Add board specific get_board_rev() callback to retrieve revision number.
> 
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
> ---
>  board/compulab/cm_t3517/cm_t3517.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/board/compulab/cm_t3517/cm_t3517.c b/board/compulab/cm_t3517/cm_t3517.c
> index 03b2bad..bf7dec2 100644
> --- a/board/compulab/cm_t3517/cm_t3517.c
> +++ b/board/compulab/cm_t3517/cm_t3517.c
> @@ -98,6 +98,15 @@ int board_init(void)
>  	return 0;
>  }
>  
> +/*
> + * Routine: get_board_rev
> + * Description: read system revision
> + */
> +u32 get_board_rev(void)
> +{
> +	return cl_eeprom_get_board_rev();

will this compile on the recent U-Boot?

> +};
> +
>  int misc_init_r(void)
>  {
>  	cl_print_pcb_info();
> 

-- 
Regards,
Igor.

[U-Boot] [PATCH v2] omap3: cm-t3517: add board specific get_board_rev()

[Dmitry Lifshitz]

CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
---

 Igor, Tom

 I forgot to add a mailing list address in send-email.
 Resending the patch.

 v2: Make proper use of cl_eeprom_get_board_rev() parameter.

 board/compulab/cm_t3517/cm_t3517.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/board/compulab/cm_t3517/cm_t3517.c b/board/compulab/cm_t3517/cm_t3517.c
index d1c74db..8aae248 100644
--- a/board/compulab/cm_t3517/cm_t3517.c
+++ b/board/compulab/cm_t3517/cm_t3517.c
@@ -98,6 +98,15 @@ int board_init(void)
 	return 0;
 }
 
+/*
+ * Routine: get_board_rev
+ * Description: read system revision
+ */
+u32 get_board_rev(void)
+{
+	return cl_eeprom_get_board_rev(CONFIG_SYS_I2C_EEPROM_BUS);
+};
+
 int misc_init_r(void)
 {
 	cl_print_pcb_info();
-- 
1.9.1

[U-Boot] [PATCH v2] omap3: cm-t3517: add board specific get_board_rev()

[Igor Grinberg]

On 11/10/15 15:17, Dmitry Lifshitz wrote:
> CM-T3517 has several HW revisions.
> Add board specific get_board_rev() callback to retrieve revision number.
> 
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>

Reviewed-by: Igor Grinberg <grinberg@compulab.co.il>

> ---
> 
>  Igor, Tom
> 
>  I forgot to add a mailing list address in send-email.
>  Resending the patch.

you may want to use aliases to simplify the stuff, check out doc/git-mailrc.

> 
>  v2: Make proper use of cl_eeprom_get_board_rev() parameter.
> 
>  board/compulab/cm_t3517/cm_t3517.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/board/compulab/cm_t3517/cm_t3517.c b/board/compulab/cm_t3517/cm_t3517.c
> index d1c74db..8aae248 100644
> --- a/board/compulab/cm_t3517/cm_t3517.c
> +++ b/board/compulab/cm_t3517/cm_t3517.c
> @@ -98,6 +98,15 @@ int board_init(void)
>  	return 0;
>  }
>  
> +/*
> + * Routine: get_board_rev
> + * Description: read system revision
> + */
> +u32 get_board_rev(void)
> +{
> +	return cl_eeprom_get_board_rev(CONFIG_SYS_I2C_EEPROM_BUS);
> +};
> +
>  int misc_init_r(void)
>  {
>  	cl_print_pcb_info();
> 

-- 
Regards,
Igor.

[U-Boot] [U-Boot, v2] omap3: cm-t3517: add board specific get_board_rev()

[Tom Rini]

On Tue, Nov 10, 2015 at 03:17:44PM +0200, Dmitry Lifshitz wrote:

> CM-T3517 has several HW revisions.
> Add board specific get_board_rev() callback to retrieve revision number.
> 
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
> Reviewed-by: Igor Grinberg <grinberg@compulab.co.il>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151118/c3d3397b/attachment.sig>