[U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass

Simon Glass
2015-10-09T09:36:38Z

Hi Thomas,

On 9 October 2015 at 02:17, Thomas Chou <thomas@wytron.com.tw> wrote:
> Implement a Timer uclass to work with lib/time.c.
>
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
> v2
> fix coding style.
> v3
> add description to Kconfig as Simon suggested.
> move timer.c code to lib/time.c.
> add dm_timer dev to global data.
> remove timer_init().
> change API name get_clock.
> v4
> add comment about timer hardware.
> v5
> revert to get_rate and use uclass priv to store the clock_rate.
> split gd->dm_timer renewal to anohter patch.
> v6
> rename to CONFIG_TIMER as Simon suggested.

But note you have changed this too broadly - 'TIMER' appears in
several places where it should be 'timer'.
>
> drivers/Kconfig | 2 ++
> drivers/Makefile | 1 +
> drivers/timer/Kconfig | 12 +++++++++
> drivers/timer/Makefile | 7 ++++++
> drivers/timer/timer-uclass.c | 42 +++++++++++++++++++++++++++++++
> include/asm-generic/global_data.h | 3 +++
> include/dm/uclass-id.h | 1 +
> include/timer.h | 52 +++++++++++++++++++++++++++++++++++++++
> lib/time.c | 49 ++++++++++++++++++++++++++++++++++++
> 9 files changed, 169 insertions(+)
> create mode 100644 drivers/timer/Kconfig
> create mode 100644 drivers/timer/Makefile
> create mode 100644 drivers/timer/timer-uclass.c
> create mode 100644 include/timer.h
>

Regards,
Simon