public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: set default cache configuration in start.S
Date: Fri, 9 Oct 2015 17:03:36 +0800	[thread overview]
Message-ID: <561782E8.3000309@wytron.com.tw> (raw)
In-Reply-To: <201510082314.46482.marex@denx.de>

Hi Marek,

On 10/09/2015 05:14 AM, Marek Vasut wrote:
> Did I miss the DT part somewhere or is that not part of this patch ?

As we are just barely starting from reset, there is no luxury of DT. 
After this, DT will be used with the cache flush patch.

> Another question I have is -- why don't we set CONFIG_SYS_{I,D}CACHE_SIZE to
> maximum value? This should work for all nios2 cache configurations and it should
> also be correct, no ? Speed might be a bit of an issue here, but I doubt the
> impact would be that large.

I am doing all the best to get rid of the CONFIG_SYS_{I,D}CACHE_SIZE...
So I avoid to use the same macro names. Here I use the maximum value in 
this startup only. The speed penalty is only once here. After we get DT 
initialized, we have the correct values of cache configuration.

It might be awful to use the maximum value all the time. See, we flush 
cache for every eth packet!

Thanks a lot for your review.

Best regards,
Thomas

  reply	other threads:[~2015-10-09  9:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06  8:21 [U-Boot] [PATCH] nios2: set default cache configuration in start.S Thomas Chou
2015-10-08 21:14 ` Marek Vasut
2015-10-09  9:03   ` Thomas Chou [this message]
2015-10-09 14:39     ` Marek Vasut
2015-10-10 12:21       ` Thomas Chou
2015-10-10 18:10         ` Marek Vasut
2015-10-09 12:11 ` [U-Boot] [PATCH v2] " Thomas Chou
2015-10-09 14:39   ` Marek Vasut
2015-10-13 13:20   ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561782E8.3000309@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox