From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Fri, 9 Oct 2015 21:18:28 +0800 Subject: [U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass In-Reply-To: References: <1443446357-21393-1-git-send-email-thomas@wytron.com.tw> <1444353477-31595-1-git-send-email-thomas@wytron.com.tw> <56179A74.4000504@wytron.com.tw> Message-ID: <5617BEA4.3060804@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Bin, On 10/09/2015 06:46 PM, Bin Meng wrote: > But in v7, it is gd->dm_timer. I think it should be gd->timer? I think it is only CONFIG_DM_TIMER, that Simon suggested to change. In the gd structure, I keep it neighbor to dm_root. In the initr_dm(), they are set to NULL similarly. So I would keep dm_ prefix. I also spelled the macro in include/timer.h as +#ifndef _DM_TIMER_H_ +#define _DM_TIMER_H_ because some archs have their timer.h. Best regards, Thomas