From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] nios2: convert dma_alloc_coherent to use memalign
Date: Sat, 10 Oct 2015 13:33:06 +0800 [thread overview]
Message-ID: <5618A312.1030306@wytron.com.tw> (raw)
In-Reply-To: <201510091649.28747.marex@denx.de>
Hi Marek,
On 10/09/2015 10:49 PM, Marek Vasut wrote:
>> + *handle = (unsigned long)memalign(ARCH_DMA_MINALIGN, len);
>
> This still modifies the handle in both cases (failure and success).
> We really want to modify external variables in case of failure, no?
The *handle return a DMA address, and the function itself return a
virtual address. Both of them should be set to NULL in case of failure.
It might be wrong to keep DMA address looks alive but actually dead.
Best regards,
Thomas Chou
next prev parent reply other threads:[~2015-10-10 5:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 2:57 [U-Boot] [PATCH] nios2: convert dma mapping to use dm cpu data Thomas Chou
2015-10-06 6:49 ` [U-Boot] [PATCH v2] nios2: convert dma_alloc_coherent to use memalign Thomas Chou
2015-10-08 21:43 ` Marek Vasut
2015-10-09 8:48 ` Thomas Chou
2015-10-09 11:35 ` Thomas Chou
2015-10-09 11:31 ` [U-Boot] [PATCH v3] " Thomas Chou
2015-10-09 14:49 ` Marek Vasut
2015-10-10 5:33 ` Thomas Chou [this message]
2015-10-10 18:19 ` Marek Vasut
2015-10-11 1:48 ` Thomas Chou
2015-10-11 12:15 ` Marek Vasut
2015-10-12 5:29 ` [U-Boot] [PATCH v4] nios2: convert dma_alloc_coherent to use malloc_cache_aligned Thomas Chou
2015-10-12 10:32 ` Marek Vasut
2015-10-12 12:55 ` Thomas Chou
2015-10-12 13:46 ` Marek Vasut
2015-10-13 0:17 ` Thomas Chou
2015-10-14 1:48 ` Thomas Chou
2015-10-16 22:53 ` Marek Vasut
2015-10-16 22:56 ` Marek Vasut
2015-10-17 2:59 ` Thomas Chou
2015-10-17 11:52 ` Marek Vasut
2015-10-19 5:52 ` Albert ARIBAUD
2015-10-19 8:18 ` Thomas Chou
2015-10-19 8:27 ` Albert ARIBAUD
2015-10-14 1:42 ` [U-Boot] [PATCH v5] " Thomas Chou
2015-10-16 8:29 ` [U-Boot] [PATCH v6] " Thomas Chou
2015-10-16 22:58 ` Marek Vasut
2015-10-18 23:46 ` Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5618A312.1030306@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox