* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init
@ 2015-10-09 20:38 Anthony Felice
2015-10-13 15:24 ` Otavio Salvador
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Anthony Felice @ 2015-10-09 20:38 UTC (permalink / raw)
To: u-boot
This commit fixes a typo in vf610twr DRAM init that was causing a hang in
U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc
(vf610: refactor DDRMC code).
Signed-off-by: Anthony Felice <tony.felice@timesys.com>
---
board/freescale/vf610twr/vf610twr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/board/freescale/vf610twr/vf610twr.c b/board/freescale/vf610twr/vf610twr.c
index a78e9e6..fa0075c 100644
--- a/board/freescale/vf610twr/vf610twr.c
+++ b/board/freescale/vf610twr/vf610twr.c
@@ -108,7 +108,7 @@ int dram_init(void)
.trcd_int = 6,
.tras_lockout = 0,
.tdal = 12,
- .bstlen = 0,
+ .bstlen = 3,
.tdll = 512,
.trp_ab = 6,
.tref = 3120,
--
1.9.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-09 20:38 [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init Anthony Felice @ 2015-10-13 15:24 ` Otavio Salvador 2015-10-13 15:28 ` Fabio Estevam ` (2 subsequent siblings) 3 siblings, 0 replies; 12+ messages in thread From: Otavio Salvador @ 2015-10-13 15:24 UTC (permalink / raw) To: u-boot On Fri, Oct 9, 2015 at 5:38 PM, Anthony Felice <tony.felice@timesys.com> wrote: > This commit fixes a typo in vf610twr DRAM init that was causing a hang in > U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc > (vf610: refactor DDRMC code). > > Signed-off-by: Anthony Felice <tony.felice@timesys.com> Seems fine for me. Stefano? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-09 20:38 [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init Anthony Felice 2015-10-13 15:24 ` Otavio Salvador @ 2015-10-13 15:28 ` Fabio Estevam 2015-10-13 15:30 ` Fabio Estevam 2015-10-14 2:47 ` Stefan Agner 2015-10-17 0:21 ` [U-Boot] " Tom Rini 3 siblings, 1 reply; 12+ messages in thread From: Fabio Estevam @ 2015-10-13 15:28 UTC (permalink / raw) To: u-boot On Fri, Oct 9, 2015 at 5:38 PM, Anthony Felice <tony.felice@timesys.com> wrote: > This commit fixes a typo in vf610twr DRAM init that was causing a hang in > U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc > (vf610: refactor DDRMC code). > > Signed-off-by: Anthony Felice <tony.felice@timesys.com> Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-13 15:28 ` Fabio Estevam @ 2015-10-13 15:30 ` Fabio Estevam 2015-10-13 20:12 ` Albert ARIBAUD 0 siblings, 1 reply; 12+ messages in thread From: Fabio Estevam @ 2015-10-13 15:30 UTC (permalink / raw) To: u-boot On Tue, Oct 13, 2015 at 12:28 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Fri, Oct 9, 2015 at 5:38 PM, Anthony Felice <tony.felice@timesys.com> wrote: >> This commit fixes a typo in vf610twr DRAM init that was causing a hang in >> U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc >> (vf610: refactor DDRMC code). >> >> Signed-off-by: Anthony Felice <tony.felice@timesys.com> > > Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com> Also, adding the author of 3f353cecc ("vf610: refactor DDRMC code") and the i.MX/Vybrid maintainer. Thanks ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-13 15:30 ` Fabio Estevam @ 2015-10-13 20:12 ` Albert ARIBAUD 2015-10-13 21:11 ` Fabio Estevam 0 siblings, 1 reply; 12+ messages in thread From: Albert ARIBAUD @ 2015-10-13 20:12 UTC (permalink / raw) To: u-boot Bonjour Fabio, Le Tue, 13 Oct 2015 12:30:47 -0300, Fabio Estevam <festevam@gmail.com> a ?crit : > On Tue, Oct 13, 2015 at 12:28 PM, Fabio Estevam <festevam@gmail.com> wrote: > > On Fri, Oct 9, 2015 at 5:38 PM, Anthony Felice <tony.felice@timesys.com> wrote: > >> This commit fixes a typo in vf610twr DRAM init that was causing a hang in > >> U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc > >> (vf610: refactor DDRMC code). > >> > >> Signed-off-by: Anthony Felice <tony.felice@timesys.com> > > > > Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com> > > Also, adding the author of 3f353cecc ("vf610: refactor DDRMC code") > and the i.MX/Vybrid maintainer. > > Thanks Thanks to Anthony for spotting and fixing this! Cordialement, Albert ARIBAUD 3ADEV ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-13 20:12 ` Albert ARIBAUD @ 2015-10-13 21:11 ` Fabio Estevam 0 siblings, 0 replies; 12+ messages in thread From: Fabio Estevam @ 2015-10-13 21:11 UTC (permalink / raw) To: u-boot Hi Stefano, On Tue, Oct 13, 2015 at 5:12 PM, Albert ARIBAUD <albert.aribaud@3adev.fr> wrote: > Thanks to Anthony for spotting and fixing this! This one fixes a regression. Please consider applying it to 2015.10. Thanks ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-09 20:38 [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init Anthony Felice 2015-10-13 15:24 ` Otavio Salvador 2015-10-13 15:28 ` Fabio Estevam @ 2015-10-14 2:47 ` Stefan Agner 2015-10-14 23:29 ` Tony Felice 2015-10-17 0:21 ` [U-Boot] " Tom Rini 3 siblings, 1 reply; 12+ messages in thread From: Stefan Agner @ 2015-10-14 2:47 UTC (permalink / raw) To: u-boot Hi Anthony, Tested on a Tower, works for me. Can you also fix the Colibri VF board? It seems to suffer the same issue, introduced by the same commit... -- Stefan On 2015-10-09 13:38, Anthony Felice wrote: > This commit fixes a typo in vf610twr DRAM init that was causing a hang in > U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc > (vf610: refactor DDRMC code). > > Signed-off-by: Anthony Felice <tony.felice@timesys.com> > --- > board/freescale/vf610twr/vf610twr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/freescale/vf610twr/vf610twr.c > b/board/freescale/vf610twr/vf610twr.c > index a78e9e6..fa0075c 100644 > --- a/board/freescale/vf610twr/vf610twr.c > +++ b/board/freescale/vf610twr/vf610twr.c > @@ -108,7 +108,7 @@ int dram_init(void) > .trcd_int = 6, > .tras_lockout = 0, > .tdal = 12, > - .bstlen = 0, > + .bstlen = 3, > .tdll = 512, > .trp_ab = 6, > .tref = 3120, ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-14 2:47 ` Stefan Agner @ 2015-10-14 23:29 ` Tony Felice 2015-10-14 23:54 ` Stefan Agner 0 siblings, 1 reply; 12+ messages in thread From: Tony Felice @ 2015-10-14 23:29 UTC (permalink / raw) To: u-boot Hi Stefan, Yes, I can submit the fix for the Colibri VF board as well - although I don't have the Colibri board to boot test on. I will be out of the office the next few days so I will submit next week. Thanks, Tony On Tue, Oct 13, 2015 at 10:47 PM, Stefan Agner <stefan@agner.ch> wrote: > Hi Anthony, > > Tested on a Tower, works for me. > > Can you also fix the Colibri VF board? It seems to suffer the same > issue, introduced by the same commit... > > -- > Stefan > > On 2015-10-09 13:38, Anthony Felice wrote: > > This commit fixes a typo in vf610twr DRAM init that was causing a hang in > > U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc > > (vf610: refactor DDRMC code). > > > > Signed-off-by: Anthony Felice <tony.felice@timesys.com> > > --- > > board/freescale/vf610twr/vf610twr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/board/freescale/vf610twr/vf610twr.c > > b/board/freescale/vf610twr/vf610twr.c > > index a78e9e6..fa0075c 100644 > > --- a/board/freescale/vf610twr/vf610twr.c > > +++ b/board/freescale/vf610twr/vf610twr.c > > @@ -108,7 +108,7 @@ int dram_init(void) > > .trcd_int = 6, > > .tras_lockout = 0, > > .tdal = 12, > > - .bstlen = 0, > > + .bstlen = 3, > > .tdll = 512, > > .trp_ab = 6, > > .tref = 3120, > > -- Tony Felice Vybrid Technical Lead Timesys Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-14 23:29 ` Tony Felice @ 2015-10-14 23:54 ` Stefan Agner 2015-10-16 6:32 ` Stefan Agner 0 siblings, 1 reply; 12+ messages in thread From: Stefan Agner @ 2015-10-14 23:54 UTC (permalink / raw) To: u-boot Hi Tony, I then realized that we are close to the release and submitted an individual patch right away. So you don't need to create a patch. Thanks for uncovering the bug and the offer. Patch, see: https://patchwork.ozlabs.org/patch/529985/ -- Stefan On 2015-10-14 16:29, Tony Felice wrote: > Hi Stefan, > > Yes, I can submit the fix for the Colibri VF board as well - although I don't have the Colibri board to boot test on. I will be out of the office the next few days so I will submit next week. > > Thanks, > > Tony > > On Tue, Oct 13, 2015 at 10:47 PM, Stefan Agner <stefan@agner.ch> wrote: > >> Hi Anthony, >> >> Tested on a Tower, works for me. >> >> Can you also fix the Colibri VF board? It seems to suffer the same >> issue, introduced by the same commit... >> >> -- >> Stefan >> >> On 2015-10-09 13:38, Anthony Felice wrote: >>> This commit fixes a typo in vf610twr DRAM init that was causing a hang in >>> U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc >>> (vf610: refactor DDRMC code). >>> >>> Signed-off-by: Anthony Felice <tony.felice@timesys.com> >>> --- >>> board/freescale/vf610twr/vf610twr.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/board/freescale/vf610twr/vf610twr.c >>> b/board/freescale/vf610twr/vf610twr.c >>> index a78e9e6..fa0075c 100644 >>> --- a/board/freescale/vf610twr/vf610twr.c >>> +++ b/board/freescale/vf610twr/vf610twr.c >>> @@ -108,7 +108,7 @@ int dram_init(void) >>> .trcd_int = 6, >>> .tras_lockout = 0, >>> .tdal = 12, >>> - .bstlen = 0, >>> + .bstlen = 3, >>> .tdll = 512, >>> .trp_ab = 6, >>> .tref = 3120, > > -- > > Tony Felice > Vybrid Technical Lead Timesys Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-14 23:54 ` Stefan Agner @ 2015-10-16 6:32 ` Stefan Agner 2015-10-16 7:32 ` Stefano Babic 0 siblings, 1 reply; 12+ messages in thread From: Stefan Agner @ 2015-10-16 6:32 UTC (permalink / raw) To: u-boot Hi Stefano, This patch did not make it into the git tree, however my patch which followed that one (and which fixed the same issue on colibri_vf only), did make it... Sorry, my comment below was somewhat confusing. I descided afterwards to just send a seperate one for colibri_vf. Could you also merge this one into 2015.10? -- Stefan On 2015-10-14 16:54, Stefan Agner wrote: > Hi Tony, > > I then realized that we are close to the release and submitted an > individual patch right away. So you don't need to create a patch. Thanks > for uncovering the bug and the offer. > > Patch, see: > https://patchwork.ozlabs.org/patch/529985/ > > -- > Stefan > > On 2015-10-14 16:29, Tony Felice wrote: > >> Hi Stefan, >> >> Yes, I can submit the fix for the Colibri VF board as well - although I don't have the Colibri board to boot test on. I will be out of the office the next few days so I will submit next week. >> >> Thanks, >> >> Tony >> >> On Tue, Oct 13, 2015 at 10:47 PM, Stefan Agner <stefan@agner.ch> wrote: >> >>> Hi Anthony, >>> >>> Tested on a Tower, works for me. >>> >>> Can you also fix the Colibri VF board? It seems to suffer the same >>> issue, introduced by the same commit... >>> >>> -- >>> Stefan >>> >>> On 2015-10-09 13:38, Anthony Felice wrote: >>>> This commit fixes a typo in vf610twr DRAM init that was causing a hang in >>>> U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc >>>> (vf610: refactor DDRMC code). >>>> >>>> Signed-off-by: Anthony Felice <tony.felice@timesys.com> >>>> --- >>>> board/freescale/vf610twr/vf610twr.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/board/freescale/vf610twr/vf610twr.c >>>> b/board/freescale/vf610twr/vf610twr.c >>>> index a78e9e6..fa0075c 100644 >>>> --- a/board/freescale/vf610twr/vf610twr.c >>>> +++ b/board/freescale/vf610twr/vf610twr.c >>>> @@ -108,7 +108,7 @@ int dram_init(void) >>>> .trcd_int = 6, >>>> .tras_lockout = 0, >>>> .tdal = 12, >>>> - .bstlen = 0, >>>> + .bstlen = 3, >>>> .tdll = 512, >>>> .trp_ab = 6, >>>> .tref = 3120, >> >> -- >> >> Tony Felice >> Vybrid Technical Lead Timesys Corporation > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init 2015-10-16 6:32 ` Stefan Agner @ 2015-10-16 7:32 ` Stefano Babic 0 siblings, 0 replies; 12+ messages in thread From: Stefano Babic @ 2015-10-16 7:32 UTC (permalink / raw) To: u-boot Hi Stefan, On 16/10/2015 08:32, Stefan Agner wrote: > Hi Stefano, > > This patch did not make it into the git tree, however my patch which > followed that one (and which fixed the same issue on colibri_vf only), > did make it... > > Sorry, my comment below was somewhat confusing. I descided afterwards to > just send a seperate one for colibri_vf. > > Could you also merge this one into 2015.10? Yes, I was quite confused. I have seen more patches (from you, Anthony and Fabio) fixing the same issue, and I missed that only two of them overlap. Fabio's patch (already merged) fixes the same issue on colibri_vf, vf610twr is still broken. I merge it and I ask Tom how to proceed. Maybe he prefer to pick it up himself. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] vf610twr: Fix typo in DRAM init 2015-10-09 20:38 [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init Anthony Felice ` (2 preceding siblings ...) 2015-10-14 2:47 ` Stefan Agner @ 2015-10-17 0:21 ` Tom Rini 3 siblings, 0 replies; 12+ messages in thread From: Tom Rini @ 2015-10-17 0:21 UTC (permalink / raw) To: u-boot On Fri, Oct 09, 2015 at 04:38:39PM -0400, Anthony Felice wrote: > This commit fixes a typo in vf610twr DRAM init that was causing a hang in > U-Boot for the Vybrid Tower. This typo was introduced in commit 3f353cecc > (vf610: refactor DDRMC code). > > Signed-off-by: Anthony Felice <tony.felice@timesys.com> > Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com> Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151016/ba726f54/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2015-10-17 0:21 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-10-09 20:38 [U-Boot] [PATCH] vf610twr: Fix typo in DRAM init Anthony Felice 2015-10-13 15:24 ` Otavio Salvador 2015-10-13 15:28 ` Fabio Estevam 2015-10-13 15:30 ` Fabio Estevam 2015-10-13 20:12 ` Albert ARIBAUD 2015-10-13 21:11 ` Fabio Estevam 2015-10-14 2:47 ` Stefan Agner 2015-10-14 23:29 ` Tony Felice 2015-10-14 23:54 ` Stefan Agner 2015-10-16 6:32 ` Stefan Agner 2015-10-16 7:32 ` Stefano Babic 2015-10-17 0:21 ` [U-Boot] " Tom Rini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox