public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] nios2: convert cache flush to use dm cpu data
Date: Sat, 17 Oct 2015 14:54:57 +0800	[thread overview]
Message-ID: <5621F0C1.6070906@wytron.com.tw> (raw)
In-Reply-To: <201510170100.05843.marex@denx.de>

Hi Marek,

On 10/17/2015 07:00 AM, Marek Vasut wrote:
>> +static void __flush_dcache(unsigned long start, unsigned long end)
>> +{
>> +	unsigned long addr;
>> +
>> +	start &= ~(gd->arch.dcache_line_size - 1);
>> +	end += (gd->arch.dcache_line_size - 1);
>> +	end &= ~(gd->arch.dcache_line_size - 1);
>
> I really don't think we should do this alignment here :-(

The rounding to get flush range is necessary to keep it confirm to the 
interface defined in linux/Documentation/cachetlb.txt.

Removing the rounding and adding "range check and keep" is a violation 
to the common interface.

You cannot agree to the common interface and, at the same time, insist 
on changing the definition by your own.

Best regards,
Thomas

  reply	other threads:[~2015-10-17  6:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1444119600-31999-1-git-send-email-thomas@wytron.com.t>
2015-10-14  1:38 ` [U-Boot] [PATCH v3] nios2: convert cache flush to use dm cpu data Thomas Chou
2015-10-16 23:00   ` Marek Vasut
2015-10-17  6:54     ` Thomas Chou [this message]
2015-10-17 11:52       ` Marek Vasut
2015-10-18 23:48   ` Thomas Chou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5621F0C1.6070906@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox