From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: zap nios2-generic board dir
Date: Mon, 19 Oct 2015 07:41:48 +0800 [thread overview]
Message-ID: <56242E3C.9080807@wytron.com.tw> (raw)
In-Reply-To: <201510181735.48599.marex@denx.de>
Hi Marek,
On 10/18/2015 11:35 PM, Marek Vasut wrote:
>> +config SYS_CONFIG_NAME
>> + string "Board header file"
>> + help
>> + This option should contain the base name of board header file.
>> + The header file include/configs/<CONFIG_SYS_CONFIG_NAME>.h
>> + should be included from include/config.h.
>
> I suspect we don't want this, since we're probing from DT. This option
> should default to something like include/configs/nios2.h , no ?
This is needed as the Kconfig doesn't cover every config option yet. We
still need a per board file. But this is supposed to be removed when
Kconfig is done for every option.
Now, the legacy board header, defconfig and dts are all that we need to
add a new board to nios2. I should add a README.nios2 after I finished
the conversion of altera_tse to driver model.
>
>> endmenu
>> diff --git a/arch/nios2/config.mk b/arch/nios2/config.mk
>> index 82bd887..2abad3f 100644
>> --- a/arch/nios2/config.mk
>> +++ b/arch/nios2/config.mk
>> @@ -10,10 +10,11 @@ ifeq ($(CROSS_COMPILE),)
>> CROSS_COMPILE := nios2-elf-
>> endif
>>
>> -CONFIG_STANDALONE_LOAD_ADDR ?= 0x02000000
>> +CONFIG_STANDALONE_LOAD_ADDR ?= 0xd2000000
>
> This doesn't look like a removal of generic board ;-)
>
>> PLATFORM_CPPFLAGS += -D__NIOS2__
>> PLATFORM_CPPFLAGS += -G0
>> +PLATFORM_CPPFLAGS += -mno-hw-div -mno-hw-mul
>
> This doesn't look that way either, you might want to split this patch
> into a series.
Yes. I will split them. Thanks a lot for your review.
Best regards,
Thomas
next prev parent reply other threads:[~2015-10-18 23:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 8:36 [U-Boot] [PATCH] nios2: zap nios2-generic board dir Thomas Chou
2015-10-18 15:35 ` Marek Vasut
2015-10-18 23:41 ` Thomas Chou [this message]
2015-10-18 23:43 ` Marek Vasut
2015-10-18 23:55 ` [U-Boot] [PATCH v2] " Thomas Chou
2015-10-23 0:18 ` Thomas Chou
2015-10-23 0:20 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56242E3C.9080807@wytron.com.tw \
--to=thomas@wytron.com.tw \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox