[U-Boot] [PATCH v3] nios2: convert dma_alloc_coherent to use memalign

Thomas Chou
2015-10-10T05:33:06Z

Hi Marek,

On 10/09/2015 10:49 PM, Marek Vasut wrote:
>> + *handle = (unsigned long)memalign(ARCH_DMA_MINALIGN, len);
>
> This still modifies the handle in both cases (failure and success).
> We really want to modify external variables in case of failure, no?

The *handle return a DMA address, and the function itself return a
virtual address. Both of them should be set to NULL in case of failure.
It might be wrong to keep DMA address looks alive but actually dead.

Best regards,
Thomas Chou